feat(core): recognize unsuffixed WebGL x3 vertex formats#2760
Draft
ibgreen wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unorm8x3anduint16x3for the existing-webglx3 vertex formatsuint8x3-webglandsint8x3-webglnamesdevice.isVertexFormatSupported()reports them as unsupported on WebGPU and WebGPU pipeline creation rejects them before they reach the native APIMotivation
deck.gl derives some attribute format strings from a component type and size. Accepting the resulting unsuffixed x3 names would let it use luma.gl's format decoder and device capability API instead of duplicating WebGPU format rules.
These aliases were not previously declared public constants, so this is intentionally separated from the backwards-compatibility fixes in #2758. It is an independent API proposal: callers can alternatively be required to emit the existing canonical
-webglnames.Validation
yarn lint fixyarn buildyarn test: all 178 node tests pass; the local headless run has the same three unrelated WebGPU failures reproduced on cleanmaster(DGGS A5 decoding and the storage-backed arrow polygon test)