feat(effects): add HDR glass showcase and emissive packet lighting#2763
Open
ibgreen-openai wants to merge 3 commits into
Open
feat(effects): add HDR glass showcase and emissive packet lighting#2763ibgreen-openai wants to merge 3 commits into
ibgreen-openai wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9bba82bae4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Changes
emissiveMaterialandopticalPointLightsshader modules and plugins, including matching WGSL/GLSL implementations and a fixed 16-light portable uniform layout.1.0through capture and resolve; update the 16-byte fragment allocation and bounded slice planning accordingly.Verification
nvm use: unavailable in this shell; the active Node version isv22.22.1.yarn install: passed usingenv -u YARN_NO_PROXY corepack yarn install.yarn build: passed usingenv -u YARN_NO_PROXY corepack yarn buildafter the final code and formatting changes.yarn lint fix: passed usingenv -u YARN_NO_PROXY corepack yarn lint fix.yarn test-node: passed, 186 tests with two skipped, including regression coverage for camera-relative WGSL/GLSL reflections and opaque reflective materials.yarn examples:typecheck: passed for 32 example workspaces.yarn website:build: passed.(cd website && yarn build): passed.test,examples, andwebsite.yarn test: Node suite passed and the browser suite reported 1,281 passing, 25 skipped, and one existing unrelated failure inmodules/arrow-layers/test/layers/arrow-layers.spec.ts(polygonViewportUniformsmissing from the Arrow polygon WebGPU shader layout). The same Arrow failure was present before these changes.Follow-up