chore: use oxc module runner transform #85
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 10, 2025
hi-ogawa
force-pushed
the
feat-oxc-module-runner-transform
branch
from
62d8c94 to
da2bfe3
Compare
commit: |
hi-ogawa
force-pushed
the
feat-oxc-module-runner-transform
branch
2 times, most recently
from
f08ac6c to
a70a869
Compare
hi-ogawa
force-pushed
the
feat-oxc-module-runner-transform
branch
from
3ba2c7e to
1c0ea36
Compare
15 tasks
sapphi-red
force-pushed
the
rolldown-vite
branch
from
9bb994c to
5546976
Compare
wip: workaround double createRequire chore: enable back pnpm override fix: fix duplicate createRequire chore: fix overrides ci: trigger preview Revert "ci: trigger preview" This reverts commit 6fb3890.
hi-ogawa
force-pushed
the
feat-oxc-module-runner-transform
branch
from
9c9d77c to
c2f718f
Compare
hi-ogawa
force-pushed
the
feat-oxc-module-runner-transform
branch
from
4e01dff to
92b3ef0
Compare
7 tasks
hi-ogawa
force-pushed
the
feat-oxc-module-runner-transform
branch
from
b47ac7a to
3607409
Compare
graphite-app bot
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Mar 12, 2025
There wasn't a test case for this on Vite, but missing re-export deps is spotted as a test case on Vitest vitest-dev/vitest#7646. I'll add a test case on Vite vitejs/rolldown-vite#85 and the same one is added here.
sapphi-red
force-pushed
the
rolldown-vite
branch
from
9ce2683 to
a974a4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For now, I grabbed
moduleRunnerTransformfromoxc-transformsince they are same. I will swap withrolldown/experimentalonce rolldown/rolldown#3801 becomes available on nightly.It looks mostly okay, but there are some suspicious diff and patch, so I'm going to look into this further.