Add FancyPicture class#18
Open
stop-upiter wants to merge 5 commits intovk-education:masterfrom
stop-upiter:master
Open
Add FancyPicture class#18stop-upiter wants to merge 5 commits intovk-education:masterfrom stop-upiter:master
stop-upiter wants to merge 5 commits intovk-education:masterfrom
stop-upiter:master
Conversation
0xera
requested changes
May 26, 2021
|
|
||
| // todo id generator | ||
|
|
||
| var image: Bitmap = pair.first |
Contributor
There was a problem hiding this comment.
data class FancyPicture(
val id: String,
val title: String,
val image: Bitmap,
val colors: List<List<String>>
)Этот класс хранит данные, попробуй сделать дата классом, Array заменить на List. String? заменить на String, Избегайте nullable по возможности.
init {
width = colors.size
length = colors[0].size
}А если массив пустой? тут init отвалится с outofboundexeption. лучше вычислять length rows/columns там где это необходимо, сделав проверку на наличие чего-либо в этом списке.
0xera
approved these changes
May 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.