Skip to content

Add FancyPicture class #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stop-upiter wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add FancyPicture class #18

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
af2e27b
Add FancyPicture class
stop-upiter May 26, 2021
4da9378
Update FancyPicture.kt
stop-upiter May 26, 2021
2da3984
Учитываем замечания и добавляем опциональные параметры автора и сложн…
May 28, 2021
e7b4e63
Update Difficulty.kt
stop-upiter May 28, 2021
21534a1
Update FancyPicture.kt
stop-upiter May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions app/src/main/java/com/example/fancywork/fancyLib/FancyPicture.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package com.example.fancywork.fancyLib

import android.graphics.Bitmap

class FancyPicture(pair: Pair<Bitmap, Array<Array<String?>>>, title: String, id: String) {

// todo id generator

var image: Bitmap = pair.first
Copy link
Contributor

@0xera 0xera May 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

data class FancyPicture(
    val id: String,
    val title: String,
    val image: Bitmap,
    val colors: List<List<String>>
)

Этот класс хранит данные, попробуй сделать дата классом, Array заменить на List. String? заменить на String, Избегайте nullable по возможности.

init {
    width = colors.size
    length = colors[0].size
}

А если массив пустой? тут init отвалится с outofboundexeption. лучше вычислять length rows/columns там где это необходимо, сделав проверку на наличие чего-либо в этом списке.

var colors: Array<Array<String?>> = pair.second

var title: String = title
var id: String = id

var width: Int
var length: Int

init {
width = colors.size
length = colors[0].size
}
}