Skip to content

Conversation

@ernie-chang
Copy link
Collaborator

Description

The run_in_docker script only run successfully on buildkite env before, so we update run_in_docker script, let users can run the script on their own local env too.

Tests

test on local v6e env log

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@dennisYehCienet dennisYehCienet changed the title update run_in_docker script for running on local env update run_in_docker script for running on local env (draft) Dec 4, 2025
@dennisYehCienet dennisYehCienet added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 4, 2025
@ernie-chang ernie-chang marked this pull request as draft December 5, 2025 01:15
@ernie-chang ernie-chang changed the title update run_in_docker script for running on local env (draft) update run_in_docker script for running on local env Dec 5, 2025
@CienetStingLin CienetStingLin marked this pull request as ready for review December 9, 2025 08:44
Copy link
Collaborator

@QiliangCui QiliangCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the variable naming change. no other concern.

@CienetStingLin CienetStingLin merged commit a5f96b8 into vllm-project:main Dec 12, 2025
6 checks passed
CienetStingLin added a commit that referenced this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants