vcsim: Consider default devs from VM spec #3937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanv
previously approved these changes
Dec 23, 2025
tenthirtyam
previously approved these changes
Dec 23, 2025
This patch updates the way vC Sim creates a new VM. Previously the VM's default devices were always added, regardless of whether or not the incoming ConfigSpec specified any of the default device info. This patch instructs vC Sim to consider the incoming ConfigSpec and check if it contains one or more of the default devices, using them from the ConfigSpec if it does. Signed-off-by: akutz <[email protected]>
akutz
force-pushed
the
fix/vcsim-vm-default-devs
branch
from
83e89ad to
a9a1a9e
Compare
Contributor
|
Tested locally, it works! |
Contributor
|
Thank you @akutz, @bryanv and @tenthirtyam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch updates the way vC Sim creates a new VM. Previously the VM's default devices were always added, regardless of whether or not the incoming ConfigSpec specified any of the default device info.
This patch instructs vC Sim to consider the incoming ConfigSpec and check if it contains one or more of the default devices, using them from the ConfigSpec if it does.
Closes:
NAHow Has This Been Tested?
The GitHub actions. Also, @fabriziopandini will test this with the Cluster API Provider for vSphere to see if it fixes his issue.
Guidelines
Please read and follow the
CONTRIBUTIONguidelines of this project.