Skip to content

vcsim: Consider default devs from VM spec #3937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akutz merged 1 commit into from
Jan 9, 2026
+222 −164
Merged

vcsim: Consider default devs from VM spec #3937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
287 changes: 125 additions & 162 deletions simulator/esx/virtual_device.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,193 +6,156 @@ package esx

import "github.com/vmware/govmomi/vim25/types"

// VirtualDevice is the default set of VirtualDevice types created for a VirtualMachine
// Capture method:
//
// govc vm.create foo
// govc object.collect -s -dump vm/foo config.hardware.device
var VirtualDevice = []types.BaseVirtualDevice{
&types.VirtualIDEController{
VirtualController: types.VirtualController{
VirtualDevice: types.VirtualDevice{
DynamicData: types.DynamicData{},
Key: 200,
DeviceInfo: &types.Description{
DynamicData: types.DynamicData{},
Label: "IDE 0",
Summary: "IDE 0",
},
Backing: nil,
Connectable: (*types.VirtualDeviceConnectInfo)(nil),
SlotInfo: nil,
ControllerKey: 0,
UnitNumber: (*int32)(nil),
},
BusNumber: 0,
Device: nil,
},
},
&types.VirtualIDEController{
VirtualController: types.VirtualController{
VirtualDevice: types.VirtualDevice{
DynamicData: types.DynamicData{},
Key: 201,
DeviceInfo: &types.Description{
DynamicData: types.DynamicData{},
Label: "IDE 1",
Summary: "IDE 1",
},
Backing: nil,
Connectable: (*types.VirtualDeviceConnectInfo)(nil),
SlotInfo: nil,
ControllerKey: 0,
UnitNumber: (*int32)(nil),
},
BusNumber: 1,
Device: nil,
},
},
&types.VirtualPS2Controller{
VirtualController: types.VirtualController{
VirtualDevice: types.VirtualDevice{
DynamicData: types.DynamicData{},
Key: 300,
DeviceInfo: &types.Description{
DynamicData: types.DynamicData{},
Label: "PS2 controller 0",
Summary: "PS2 controller 0",
},
Backing: nil,
Connectable: (*types.VirtualDeviceConnectInfo)(nil),
SlotInfo: nil,
ControllerKey: 0,
UnitNumber: (*int32)(nil),
const (
VirtualMachineDefaultDevicePCIControllerKey = int32(100)
VirtualMachineDefaultDevicePS2ControllerKey = int32(300)
)

var VirtualMachineDefaultDevicePCIController = &types.VirtualPCIController{
VirtualController: types.VirtualController{
VirtualDevice: types.VirtualDevice{
Key: VirtualMachineDefaultDevicePCIControllerKey,
DeviceInfo: &types.Description{
Label: "PCI controller 0",
Summary: "PCI controller 0",
},
BusNumber: 0,
Device: []int32{600, 700},
},
},
&types.VirtualPCIController{
VirtualController: types.VirtualController{
VirtualDevice: types.VirtualDevice{
DynamicData: types.DynamicData{},
Key: 100,
DeviceInfo: &types.Description{
DynamicData: types.DynamicData{},
Label: "PCI controller 0",
Summary: "PCI controller 0",
},
Backing: nil,
Connectable: (*types.VirtualDeviceConnectInfo)(nil),
SlotInfo: nil,
ControllerKey: 0,
UnitNumber: (*int32)(nil),
},
BusNumber: 0,
Device: []int32{500, 12000},
Device: []int32{
VirtualMachineDefaultDeviceVideoCard.Key,
VirtualMachineDefaultDeviceVMCIDevice.Key,
},
},
&types.VirtualSIOController{
VirtualController: types.VirtualController{
VirtualDevice: types.VirtualDevice{
DynamicData: types.DynamicData{},
Key: 400,
DeviceInfo: &types.Description{
DynamicData: types.DynamicData{},
Label: "SIO controller 0",
Summary: "SIO controller 0",
},
Backing: nil,
Connectable: (*types.VirtualDeviceConnectInfo)(nil),
SlotInfo: nil,
ControllerKey: 0,
UnitNumber: (*int32)(nil),
}

var VirtualMachineDefaultDeviceIDEControllerBus0 = &types.VirtualIDEController{
VirtualController: types.VirtualController{
VirtualDevice: types.VirtualDevice{
Key: 200,
DeviceInfo: &types.Description{
Label: "IDE 0",
Summary: "IDE 0",
},
BusNumber: 0,
Device: nil,
},
BusNumber: 0,
},
&types.VirtualKeyboard{
}

var VirtualMachineDefaultDeviceIDEControllerBus1 = &types.VirtualIDEController{
VirtualController: types.VirtualController{
VirtualDevice: types.VirtualDevice{
DynamicData: types.DynamicData{},
Key: 600,
Key: 201,
DeviceInfo: &types.Description{
DynamicData: types.DynamicData{},
Label: "Keyboard ",
Summary: "Keyboard",
Label: "IDE 1",
Summary: "IDE 1",
},
Backing: nil,
Connectable: (*types.VirtualDeviceConnectInfo)(nil),
SlotInfo: nil,
ControllerKey: 300,
UnitNumber: types.NewInt32(0),
},
BusNumber: 1,
},
&types.VirtualPointingDevice{
}

var VirtualMachineDefaultDevicePS2Controller = &types.VirtualPS2Controller{
VirtualController: types.VirtualController{
VirtualDevice: types.VirtualDevice{
DynamicData: types.DynamicData{},
Key: 700,
Key: VirtualMachineDefaultDevicePS2ControllerKey,
DeviceInfo: &types.Description{
DynamicData: types.DynamicData{},
Label: "Pointing device",
Summary: "Pointing device; Device",
},
Backing: &types.VirtualPointingDeviceDeviceBackingInfo{
VirtualDeviceDeviceBackingInfo: types.VirtualDeviceDeviceBackingInfo{
VirtualDeviceBackingInfo: types.VirtualDeviceBackingInfo{},
DeviceName: "",
UseAutoDetect: types.NewBool(false),
},
HostPointingDevice: "autodetect",
Label: "PS2 controller 0",
Summary: "PS2 controller 0",
},
Connectable: (*types.VirtualDeviceConnectInfo)(nil),
SlotInfo: nil,
ControllerKey: 300,
UnitNumber: types.NewInt32(1),
},
Device: []int32{
VirtualMachineDefaultDeviceVirtualKeyboard.Key,
VirtualMachineDefaultDeviceVirtualPointingDevice.Key,
},
},
&types.VirtualMachineVideoCard{
}

var VirtualMachineDefaultDeviceSIOController = &types.VirtualSIOController{
VirtualController: types.VirtualController{
VirtualDevice: types.VirtualDevice{
DynamicData: types.DynamicData{},
Key: 500,
Key: 400,
DeviceInfo: &types.Description{
DynamicData: types.DynamicData{},
Label: "Video card ",
Summary: "Video card",
Label: "SIO controller 0",
Summary: "SIO controller 0",
},
Backing: nil,
Connectable: (*types.VirtualDeviceConnectInfo)(nil),
SlotInfo: nil,
ControllerKey: 100,
UnitNumber: types.NewInt32(0),
},
VideoRamSizeInKB: 4096,
NumDisplays: 1,
UseAutoDetect: types.NewBool(false),
Enable3DSupport: types.NewBool(false),
Use3dRenderer: "automatic",
GraphicsMemorySizeInKB: 262144,
},
&types.VirtualMachineVMCIDevice{
VirtualDevice: types.VirtualDevice{
DynamicData: types.DynamicData{},
Key: 12000,
DeviceInfo: &types.Description{
DynamicData: types.DynamicData{},
Label: "VMCI device",
Summary: "Device on the virtual machine PCI bus that provides support for the virtual machine communication interface",
}
var VirtualMachineDefaultDeviceVirtualKeyboard = &types.VirtualKeyboard{
VirtualDevice: types.VirtualDevice{
Key: 600,
DeviceInfo: &types.Description{
Label: "Keyboard ",
Summary: "Keyboard",
},
ControllerKey: VirtualMachineDefaultDevicePS2ControllerKey,
UnitNumber: types.NewInt32(0),
},
}
var VirtualMachineDefaultDeviceVirtualPointingDevice = &types.VirtualPointingDevice{
VirtualDevice: types.VirtualDevice{
Key: 700,
DeviceInfo: &types.Description{
Label: "Pointing device",
Summary: "Pointing device; Device",
},
Backing: &types.VirtualPointingDeviceDeviceBackingInfo{
VirtualDeviceDeviceBackingInfo: types.VirtualDeviceDeviceBackingInfo{
UseAutoDetect: types.NewBool(false),
},
Backing: nil,
Connectable: (*types.VirtualDeviceConnectInfo)(nil),
SlotInfo: nil,
ControllerKey: 100,
UnitNumber: types.NewInt32(17),
HostPointingDevice: "autodetect",
},
ControllerKey: VirtualMachineDefaultDevicePS2ControllerKey,
UnitNumber: types.NewInt32(1),
},
}
var VirtualMachineDefaultDeviceVideoCard = &types.VirtualMachineVideoCard{
VirtualDevice: types.VirtualDevice{
Key: 500,
DeviceInfo: &types.Description{
Label: "Video card ",
Summary: "Video card",
},
ControllerKey: VirtualMachineDefaultDevicePCIControllerKey,
UnitNumber: types.NewInt32(0),
},
VideoRamSizeInKB: 4096,
NumDisplays: 1,
UseAutoDetect: types.NewBool(false),
Enable3DSupport: types.NewBool(false),
Use3dRenderer: "automatic",
GraphicsMemorySizeInKB: 262144,
}

var VirtualMachineDefaultDeviceVMCIDevice = &types.VirtualMachineVMCIDevice{
VirtualDevice: types.VirtualDevice{
Key: 12000,
DeviceInfo: &types.Description{
Label: "VMCI device",
Summary: "Device on the virtual machine PCI bus that provides support for the virtual machine communication interface",
},
Id: -1,
AllowUnrestrictedCommunication: types.NewBool(false),
FilterEnable: types.NewBool(true),
FilterInfo: (*types.VirtualMachineVMCIDeviceFilterInfo)(nil),
ControllerKey: VirtualMachineDefaultDevicePCIControllerKey,
UnitNumber: types.NewInt32(17),
},
Id: -1,
AllowUnrestrictedCommunication: types.NewBool(false),
FilterEnable: types.NewBool(true),
}

// VirtualDevice is the default set of VirtualDevice types created for a VirtualMachine
// Capture method:
//
// govc vm.create foo
// govc object.collect -s -dump vm/foo config.hardware.device
var VirtualDevice = []types.BaseVirtualDevice{
VirtualMachineDefaultDevicePCIController,
VirtualMachineDefaultDeviceIDEControllerBus0,
VirtualMachineDefaultDeviceIDEControllerBus1,
VirtualMachineDefaultDevicePS2Controller,
VirtualMachineDefaultDeviceSIOController,
VirtualMachineDefaultDeviceVirtualKeyboard,
VirtualMachineDefaultDeviceVirtualPointingDevice,
VirtualMachineDefaultDeviceVideoCard,
VirtualMachineDefaultDeviceVMCIDevice,
}

// EthernetCard template for types.VirtualEthernetCard
Expand Down
Loading
Loading