refactor: split aruco detector to ros and lib

[AntTra]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (3656250) to head (9be7306).

Files with missing lines	Patch %	Lines
aruco-detector/src/lib/aruco_file_logger.cpp	0.00%	34 Missing ⚠️
aruco-detector/src/ros/aruco_detector_ros.cpp	0.00%	18 Missing ⚠️
aruco-detector/src/lib/aruco_detector.cpp	0.00%	3 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff          @@
##            main     #13   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          4       4           
  Lines        282     291    +9     
  Branches      28      29    +1     
=====================================
- Misses       282     291    +9     

Flag	Coverage Δ
unittests	0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../include/aruco_detector/ros/aruco_detector_ros.hpp	0.00% <ø> (ø)
aruco-detector/src/lib/aruco_detector.cpp	0.00% <0.00%> (ø)
aruco-detector/src/ros/aruco_detector_ros.cpp	0.00% <0.00%> (ø)
aruco-detector/src/lib/aruco_file_logger.cpp	0.00% <0.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jorgenfj]

dictionary_map declared in aruco_detector_ros.hpp should be moved to /lib.
Also logging functionality should be moved to lib/ and be made ros independent.

I also have a few pointers for a more fine-grained refactor. Let me know if that is wanted

[kluge7]

As part of this pull request, this issue will also be implemented: #11

[jorgenfj]

As part of this pull request, this issue will also be implemented: #11

Aha! You have completed all your tasks and have been awared with more work!

Good job

[jorgenfj]

I think it makes sense to make some of the cluttered return types into structs instead of tuples.
We should have one simple function to detect aruco markers that is just a wrapper around the OpenCV call. Then we can make the other functions like estimate pose and estimate board pose, input the marker corners and ids from the initial detect aruco markers call. The estimate pose and estimate board pose should return the vortex::utils::types::Pose type ideally

[jorgenfj]

Does it make sense to split standard aruco marker detection and the board detection into two separate classes?