v9.1.0 - #136
Merged
Merged
Conversation
This was referenced Aug 10, 2026
Closed
Append additive fields after the 9.0.2 constructor arguments, cover old positional calls, and make Docker propagate the dotnet test exit code.
Drop the property reordering that kept model constructors positionally compatible with 9.0.2. It only shifted parameter order, never the JSON contract, and the project has shipped the same generator churn in past minors. The changelog now states that positional constructor calls need updating, and the test asserting the old order is gone.
Spell out that ApplicableTo/InapplicableTo positional calls can silently misbind, while Segments* usually fail at compile time. Named arguments, initializers and JSON deserialization stay safe.
Campaign voucher generation is async, so a 2–3s sleep raced and left tests indexing an empty list. Co-authored-by: Cursor <cursoragent@cursor.com>
Updated readme to contain information on what changed in the tests
kasjankotyniarsp
approved these changes
Aug 20, 2026
kasjankotyniarsp
left a comment
kasjankotyniarsp
left a comment
Contributor
There was a problem hiding this comment.
Readme looks ok. Flanky tests updated.
patryksmolarz
approved these changes
Aug 20, 2026
Update readme and nuspec release notes: 2026-08-20 date, constructor migration note, test polling and Docker exit-code propagation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
9.1.0for theno_effectfix plus the accumulated additive OpenAPI sync.NoEffect(no_effect) member to the skipped-redeemableKeyEnum. PreviouslyKeybecamenullthroughSafeEnumConverterwhen the API skipped a redeemable with no discount effect.9.1.0changelog:STANDALONE,ADD_SAME_ITEMS, segmentUpdatedAt, product quantity limits, customer asset fields and theCreatePublicationCampaign.Countmaximum increase from 20 to 50.dotnet testexit code.Supersedes #135 (the earlier
9.0.3patch attempt, now closed).OpenAPI: voucherifyio/voucherify-openapi#1346 · tag
sdk-dotnet-9.1.0Public surface change worth reviewing
Constructor parameter order changes on
ApplicableTo,InapplicableTo,SegmentsCreateResponseBodyandSegmentsGetResponseBodybecause new optional properties occur before previously trailing properties in the definition.ApplicableTo/InapplicableTocan silently bind trailing arguments to new quantity-limit parameters.SegmentsCreateResponseBody/SegmentsGetResponseBodyusually fail at compile time becauseupdatedAtis inserted beforetype.9.1.0follows this SDK's existing release practice:8.0.1→8.1.0was a minor release that similarly inserted constructor parameters in 82 models. This release documents the migration explicitly.Test plan
npm run test-dotnet-sdkfrom the OpenAPI repository — 37 tests, passKeyEnum.NoEffectpresent and maps from"no_effect"9.1.0consistent across csproj, nuspec, Configuration and READMECountlimit increaseredeemables_no_effect_rule=SKIPKnown issue (deliberately out of scope)
The SDK retains four misspelled management webhook enum members inherited from the source OpenAPI definition. This is not a regression:
9.0.2shipped the same members.Correcting the spelling would rename public enum members. It will therefore be handled across SDKs through additive aliases in a future alignment, or as part of a major release.