PHP 5.1.0, Python 6.1.0, .NET 9.1.0 — no_effect + OpenAPI sync (minor) - #1346
Open
p-zielinski wants to merge 14 commits into
Open
PHP 5.1.0, Python 6.1.0, .NET 9.1.0 — no_effect + OpenAPI sync (minor)#1346p-zielinski wants to merge 14 commits into
p-zielinski wants to merge 14 commits into
Conversation
Correct SemVer after regen audit: restore PHP BC in prepare script (webhook *_added spellings, stable CSV import signature), expand changelogs, point submodules at minor release branches.
p-zielinski
changed the title
Keep additive .NET fields after existing positional arguments and update all three SDK pointers after successful Docker verification.
The PHP datetime filter now sends the documented $more_than / $less_than keys, which is a wire-level change consumers need in the changelog. The Python readme still pointed at the 6.0.0 OpenAPI tag.
This was referenced Aug 10, 2026
Both scripts patched the OpenAPI definition before generation to keep the previous public surface: PHP restored the added spelling of four management webhook events and dropped webhooks_enable, .NET pushed new optional properties to the end of four schemas. The compensations made the prepared specs diverge from reference/OpenAPI.json and hid real upstream changes from reviewers. Both SDKs are now generated from the definition as-is and the effects are spelled out in their changelogs. Versions stay at 5.1.0 and 9.1.0: this project has shipped the same class of generator churn in minors (.NET 8.1.0 reordered 82 constructors) and even patches (PHP 5.0.2 dropped eight public constants). The aded typo itself is upstream and tracked in DEV-4148.
Reinstates the php.ts prepare-step fixes that the earlier revert removed: it rewrites four ManagementProjectsWebhookBase events from the upstream aded typo back to added, and drops webhooks_enable from the CSV import body so importVouchersUsingCsv keeps its 5.0.4 signature. Without this the SDK renamed public EVENTS_*_ADDED constants and shifted a positional parameter, both breaking. The changelog no longer advertises those as changes. Source reference/OpenAPI.json is left untouched; the typo is fixed for every SDK at once under DEV-4148.
Document silent misbind on ApplicableTo/InapplicableTo versus compile-time breaks on Segments* when using positional constructors.
Tighten the backward-compatibility note, document the intentionally omitted webhooks_enable CSV field, and replace internal tracker links with a reference to a future SDK alignment.
p-zielinski
requested review from
karol-voucherify,
p-woznikowski,
patryksmolarz and
ppikula-90
August 11, 2026 14:39
Add Kasjan test polling and Docker exit-code notes to csharp README.mustache; bump sdks/dotnet to 0c8f6d8 (9.1.0 branch).
Add OpenAPI tree tag link, KEY_NO_EFFECT, adjustMemberPendingPoints and TYPE_STANDALONE wording to php-nextgen README.mustache; bump sdks/php to a17370b.
Points to 0d01700 (master merged into versions/5.1.0, release README kept).
Resolve sdks/dotnet submodule conflict by keeping 0c8f6d8 (9.1.0 release branch) instead of master's b037424 readme-only pointer. PHP and Python release submodules unchanged.
Point sdks/python to a5a3a19 (merge conflict fix + docstring regen); use /tree/ OpenAPI tag URL in python README.mustache.
…and sync Python 6.1.0. Change exchange_ratio from integer to number in RedemptionRewardResult, update the Python README mustache changelog, and bump the Python submodule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
no_effectskipped-redeemable key to PHP, Python and .NET (Java17.0.4already includes it).Versions
5.1.06.1.09.1.017.0.4Release source tags:
sdk-php-5.1.0,sdk-python-6.1.0,sdk-dotnet-9.1.0.Per-language preparation and compatibility
php.tsrestores four management webhook values from the source typo*_adedto*_added, preserving existingEVENTS_*_ADDEDconstants. It also omitswebhooks_enablefrom CSV voucher import soimportVouchersUsingCsv($file, $contentType)retains its5.0.4signature. The prepared PHP specification intentionally differs from the source in these places.6.0.0.ApplicableTo/InapplicableTocan silently misbind; positionalSegments*ResponseBodycalls usually fail at compile time. Named arguments, object initializers and JSON deserialization are unaffected, and JSON member names do not change.Versioning notes
5.1.0has no removed or renamed public API surface; its observable wire-key change inFilterConditionsDateTimeis a documented bug fix.6.1.0is additive.9.1.0follows the SDK's established minor-release practice:8.0.1→8.1.0similarly inserted constructor parameters in 82 models. The migration is documented explicitly in this release.Test plan
no_effectpresent on skipped-redeemable details in all three SDKs5.0.4Known issue (deliberately out of scope)
The source OpenAPI definition misspells four management webhook events as
*_aded, while equivalent events elsewhere use*_added. PHP compensates during generation to preserve existing public constants. Python, .NET, Java and Ruby already retain the source spelling from earlier releases.The spelling will be aligned across SDKs in a future compatibility release or major version, avoiding unexpected public enum renames.