Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6322: Include microcode in amd64 architecture builds #922

Open
wants to merge 1 commit into
base: current
Choose a base branch
from

Conversation

Embezzle
Copy link

@Embezzle Embezzle commented Mar 2, 2025

Change summary

Include Intel & AMD microcode packages in amd64 architecture builds.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T6322

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@Embezzle Embezzle requested a review from a team as a code owner March 2, 2025 17:51
Copy link

github-actions bot commented Mar 2, 2025

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Mar 2, 2025
]

[additional_repositories.firmware]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why is it needed — we already have non-free-firmware enabled in https://github.com/vyos/vyos-build/blob/current/data/defaults.toml Did you find any issues there?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without specifying the non-free-firmware component here the build fails, as it cannot find the packages.
Although it's not too clear to me why... Like you mentioned it is already specified in the defaults.toml.

Package intel-microcode is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

Package amd64-microcode is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current VyOS rolling release
Development

Successfully merging this pull request may close these issues.

3 participants