Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'generic-microcode' flavor #2

Closed
wants to merge 1 commit into from

Conversation

Embezzle
Copy link

Change Summary

Added generic-microcode flavor which incorporates Intel & AMD microcode packages.
This can be useful in bare metal deployments, where a CPU requires updated microcode to patch vulnerabilities.

Checklist:

Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nothing against it, but i wonder: is there a reason why we cannot have them in the x86 image by default?

The flavor system supports architecture mix-ins, like https://github.com/vyos/vyos-build/blob/current/data/architectures/amd64.toml
So if the only reason to exclude them is not to clutter images for ARM64 and other architectures with useless files, that would be a perfect place to add them.

Or I'm missing anything and those microcode files can be problematic in some VMs or in some scenarios?

@Embezzle
Copy link
Author

Embezzle commented Mar 2, 2025

I have nothing against it, but i wonder: is there a reason why we cannot have them in the x86 image by default?

The flavor system supports architecture mix-ins, like https://github.com/vyos/vyos-build/blob/current/data/architectures/amd64.toml So if the only reason to exclude them is not to clutter images for ARM64 and other architectures with useless files, that would be a perfect place to add them.

Or I'm missing anything and those microcode files can be problematic in some VMs or in some scenarios?

I strongly agree that microcode should be included in the default generic flavor, but it was unclear to me if the maintainers shared this view. If you are open to this approach, I am happy to send that PR instead.

It should not be an issue if microcode packages are included in VMs, they will simply be ignored. From experience this is not problematic in KVM.

@dmbaturin
Copy link
Member

Superseded by vyos/vyos-build#922

@dmbaturin dmbaturin closed this Mar 4, 2025
@Embezzle Embezzle deleted the generic-microcode branch March 4, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants