Skip to content

Remove the numerical error codes to be in sync with the VCDM specification #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

iherman
Copy link
Member

@iherman iherman commented Jan 6, 2025

This is the sister PR to w3c/vc-data-integrity#327 removing the numerical codes from the error entries. See w3c/vc-data-integrity#327 for further description of the changes.


Preview | Diff

@iherman iherman requested a review from dlongley January 6, 2025 16:07
@iherman
Copy link
Member Author

iherman commented Jan 8, 2025

The issue was discussed in a meeting on 2025-01-08

  • no resolutions were taken
View the transcript

3.1. Remove the numerical error codes to be in sync with the VCDM specification (pr cid#140)

See github pull request cid#140.

Brent Zundel: Remove numerical error codes to be in sync with the VCDM spec.

Manu Sporny: +1 to this change.

Brent Zundel: It does what it says. It removes the error codes while retaining the names of the error codes. Anyone want to say we don't want to do this, please say so, can take comments briefly, etc. if needed.

Ivan Herman: Just remarking that there is a sister PR in the DI spec which does the same. It also makes the changes in the vocab definition file. These two PRs should go hand-in-hand.

See github pull request vc-data-integrity#327.

Manu Sporny: Yes, +1 -- we made a decision in the group to remove the error codes in the group and this is just Ivan making sure we follow that guidance.

Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor but important clean up then +1. I see VCDM's problem details isn't in sync with bitstring status list either, looks like we should just loosen VCDM and then everything will be in sync and will also match the RFC requirements (advisory only), see: https://www.rfc-editor.org/rfc/rfc9457#name-title.

iherman and others added 2 commits January 20, 2025 08:16
Co-authored-by: Dave Longley <[email protected]>
Co-authored-by: Dave Longley <[email protected]>
@msporny
Copy link
Member

msporny commented Jan 20, 2025

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit fbb25fe into main Jan 20, 2025
1 check passed
@msporny msporny deleted the remove-error-codes branch January 20, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants