Skip to content

Fix review comments on ember/template-no-deprecated#1

Merged
wagenet merged 4 commits intopwn/template-no-deprecatedfrom
copilot/fix-comments-after-commit
Feb 27, 2026
Merged

Fix review comments on ember/template-no-deprecated#1
wagenet merged 4 commits intopwn/template-no-deprecatedfrom
copilot/fix-comments-after-commit

Conversation

Copy link

Copilot AI commented Feb 27, 2026

Addresses open review comments from the most recent commit on the ember/template-no-deprecated rule.

Docs (docs/rules/template-no-deprecated.md)

  • @arg deprecation checking is already implemented via GlimmerAttrNode — remove the "Not covered" note and add it to the covered syntax table

Tests (tests/lib/rules/template-no-deprecated.js)

  • Replace multi-line template literals with single-line strings + explicit \n to eliminate invisible whitespace (makes column positions easier to debug)
  • Drop redundant — no error suffixes from valid comments
  • Add sub-expression test case: {{fn (deprecatedHelper)}}

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI and others added 2 commits February 27, 2026 19:26
Co-authored-by: wagenet <9835+wagenet@users.noreply.github.com>
…xpression test

Co-authored-by: wagenet <9835+wagenet@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix comments added after recent commit Fix review comments on template-no-deprecated rule Feb 27, 2026
Co-authored-by: wagenet <9835+wagenet@users.noreply.github.com>
Copilot AI changed the title Fix review comments on template-no-deprecated rule Fix review comments on ember/template-no-deprecated Feb 27, 2026
@wagenet wagenet marked this pull request as ready for review February 27, 2026 19:34
@wagenet wagenet merged commit 7d0e5f0 into pwn/template-no-deprecated Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants