Skip to content

Fix review comments on ember/template-no-deprecated #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wagenet merged 4 commits into from
Feb 27, 2026
Merged

Fix review comments on ember/template-no-deprecated #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c410eb6
Initial plan
Copilot Feb 27, 2026
2df429d
Initial plan
Copilot Feb 27, 2026
58d3dfd
Fix review comments: update docs, clean up test whitespace, add sub-e…
Copilot Feb 27, 2026
9c73644
Revert package-lock.json addition to .gitignore
Copilot Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions docs/rules/template-no-deprecated.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ This rule checks if imported Glimmer components, helpers, or modifiers are marke
| Helper / value mustache | `{{deprecatedHelper}}` |
| Block component | `{{#DeprecatedBlock}}…{{/DeprecatedBlock}}` |
| Modifier | `<div {{deprecatedModifier}}>` |

**Not covered:** `<MyComp @deprecatedArg={{x}}>` — checking argument deprecations is not yet implemented.
| Component argument | `<MyComp @deprecatedArg={{x}}>` |

## Examples

Expand Down
61 changes: 20 additions & 41 deletions tests/lib/rules/template-no-deprecated.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,83 +58,65 @@ const ruleTesterTyped = new RuleTester({

ruleTesterTyped.run('template-no-deprecated (with TS project)', rule, {
valid: [
// Non-deprecated component — no error
// Non-deprecated component
{
filename: path.join(FIXTURES_DIR, 'usage.gts'),
code: `
import CurrentComponent from './current-component';
<template><CurrentComponent /></template>
`,
code: "import CurrentComponent from './current-component';\n<template><CurrentComponent /></template>",
},
// Plain HTML tag
{
filename: path.join(FIXTURES_DIR, 'usage.gts'),
code: `
<template><div></div></template>
`,
code: '<template><div></div></template>',
},
// this.something — no scope reference
{
filename: path.join(FIXTURES_DIR, 'usage.gts'),
code: `
<template>{{this.foo}}</template>
`,
code: '<template>{{this.foo}}</template>',
},
// Non-deprecated @arg — no error
// Non-deprecated @arg
{
filename: path.join(FIXTURES_DIR, 'usage.gts'),
code: `
import ComponentWithArgs from './component-with-args';
<template><ComponentWithArgs @newArg='x' /></template>
`,
code: "import ComponentWithArgs from './component-with-args';\n<template><ComponentWithArgs @newArg='x' /></template>",
},
// @arg on a component with no typed Args — silently skip
// @arg on a component with no typed Args
{
filename: path.join(FIXTURES_DIR, 'usage.gts'),
code: `
import CurrentComponent from './current-component';
<template><CurrentComponent @anyArg='x' /></template>
`,
code: "import CurrentComponent from './current-component';\n<template><CurrentComponent @anyArg='x' /></template>",
},
],
invalid: [
// Deprecated component in element position
{
filename: path.join(FIXTURES_DIR, 'usage.gts'),
code: `
import DeprecatedComponent from './deprecated-component';
<template><DeprecatedComponent /></template>
`,
code: "import DeprecatedComponent from './deprecated-component';\n<template><DeprecatedComponent /></template>",
output: null,
errors: [{ messageId: 'deprecatedWithReason', type: 'GlimmerElementNodePart' }],
},
// Deprecated helper in mustache position
{
filename: path.join(FIXTURES_DIR, 'usage.gts'),
code: `
import { deprecatedHelper } from './deprecated-helper';
<template>{{deprecatedHelper}}</template>
`,
code: "import { deprecatedHelper } from './deprecated-helper';\n<template>{{deprecatedHelper}}</template>",
output: null,
errors: [{ messageId: 'deprecated', type: 'VarHead' }],
},
// Deprecated helper in sub-expression position
{
filename: path.join(FIXTURES_DIR, 'usage.gts'),
code: "import { deprecatedHelper } from './deprecated-helper';\n<template>{{fn (deprecatedHelper)}}</template>",
output: null,
errors: [{ messageId: 'deprecated', type: 'VarHead' }],
},
// Deprecated component in block position
{
filename: path.join(FIXTURES_DIR, 'usage.gts'),
code: `
import DeprecatedComponent from './deprecated-component';
<template>{{#DeprecatedComponent}}{{/DeprecatedComponent}}</template>
`,
code: "import DeprecatedComponent from './deprecated-component';\n<template>{{#DeprecatedComponent}}{{/DeprecatedComponent}}</template>",
output: null,
errors: [{ messageId: 'deprecatedWithReason', type: 'VarHead' }],
},
// Deprecated @arg with reason
{
filename: path.join(FIXTURES_DIR, 'usage.gts'),
code: `
import ComponentWithArgs from './component-with-args';
<template><ComponentWithArgs @oldArg='x' /></template>
`,
code: "import ComponentWithArgs from './component-with-args';\n<template><ComponentWithArgs @oldArg='x' /></template>",
output: null,
errors: [
{
Expand All @@ -146,10 +128,7 @@ ruleTesterTyped.run('template-no-deprecated (with TS project)', rule, {
// Deprecated @arg without reason
{
filename: path.join(FIXTURES_DIR, 'usage.gts'),
code: `
import ComponentWithArgs from './component-with-args';
<template><ComponentWithArgs @oldArgNoReason='x' /></template>
`,
code: "import ComponentWithArgs from './component-with-args';\n<template><ComponentWithArgs @oldArgNoReason='x' /></template>",
output: null,
errors: [{ messageId: 'deprecated', data: { name: '@oldArgNoReason' } }],
},
Expand Down