Ensure check-host-key returns host key from the actual host being checked, not from first jump host - #2413
Closed
EdMcBane wants to merge 1 commit into
Closed
Ensure check-host-key returns host key from the actual host being checked, not from first jump host#2413EdMcBane wants to merge 1 commit into
EdMcBane wants to merge 1 commit into
Conversation
4 tasks
4 tasks
Member
|
Thank you for the PR! Parts of the infrastructure for it have already landed in parallel as a fix for GHSA-w9jj-vpw3-5r8f and I wasn't able to push to your branch, so I've moved my remaining fix into #2437 and close this one @all-contributors add @EdMcBane for code |
Contributor
|
I've put up a pull request to add @infrastructure! 🎉 |
Member
|
@all-contributors add @EdMcBane for code |
Contributor
|
I've put up a pull request to add @EdMcBane! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When resolving the ssh chain, track the
target_idfor each host, and feed it back into the raisedHostKeyReceived/HostKeyUnknownRCEvents, so that the procedure can match the one for the actual check target and break out only for it.Fixes #2412
The implementation can be improved, I'm not too fond of having the target_id being a tuple field in multiple places.
Firing this off so it can receive review and feedback before being finalized.
AI Usage
Choose the level of AI involvement for this PR.