Skip to content

Commit

Permalink
chore: continue clean up workflow (#9308)
Browse files Browse the repository at this point in the history
  • Loading branch information
@hardfist
hardfist authored Feb 14, 2025
1 parent f34377a commit b8488a5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 57 deletions.
3 changes: 1 addition & 2 deletions .github/actions/rustup/action.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -88,5 +88,4 @@ runs:
uses: Swatinem/rust-cache@f0deed1e0edfc6a9be95417288c0e1099b1eeec3 # v2
if: ${{ startsWith(runner.name, 'GitHub Actions') }}
with:
shared-key: ${{ inputs.shared-key }}
save-if: ${{ inputs.save-cache == 'true' }}
shared-key: ${{ inputs.shared-key }}
54 changes: 0 additions & 54 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ on:
tags-ignore:
- "**"

env:
# Since CI builds are more akin to from-scratch builds, incremental compilation adds unnecessary dependency-tracking and IO overhead, reducing caching effectiveness.
# https://github.com/rust-lang/rust-analyzer/blob/25368d24308d6a94ffe8b99f0122bcf5a2175322/.github/workflows/ci.yaml#L11
CARGO_INCREMENTAL: 0

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
cancel-in-progress: ${{ github.ref_name != 'main' }}
Expand Down Expand Up @@ -74,23 +69,6 @@ jobs:
skipable: ${{ needs.check-changed.outputs.changed != 'true' }}
bench: true

test-release-linux:
name: Test Release Linux
needs: [get-runner-labels]
if: contains(github.event.pull_request.title, '!linux')
uses: ./.github/workflows/reusable-build.yml
strategy:
fail-fast: false # Build and test everything so we can look at all the errors
matrix:
array:
- target: x86_64-unknown-linux-gnu
- target: aarch64-unknown-linux-gnu
- target: x86_64-unknown-linux-musl
- target: aarch64-unknown-linux-musl
with:
target: ${{ matrix.array.target }}
runner: ${{ needs.get-runner-labels.outputs.LINUX_RUNNER_LABELS }}

test-windows:
name: Test Windows
needs: [get-runner-labels, check-changed]
Expand All @@ -100,23 +78,6 @@ jobs:
profile: "dev"
runner: ${{ needs.get-runner-labels.outputs.WINDOWS_RUNNER_LABELS }}
skipable: ${{ needs.check-changed.outputs.changed != 'true' }}

test-release-windows:
name: Test Release Windows
needs: [get-runner-labels]
if: contains(github.event.pull_request.title, '!windows')
uses: ./.github/workflows/reusable-build.yml
strategy:
fail-fast: false # Build and test everything so we can look at all the errors
matrix:
array:
- target: i686-pc-windows-msvc
- target: x86_64-pc-windows-msvc
- target: aarch64-pc-windows-msvc
with:
target: ${{ matrix.array.target }}
runner: ${{ needs.get-runner-labels.outputs.WINDOWS_RUNNER_LABELS }}

test-mac:
name: Test Mac
needs: [get-runner-labels, check-changed]
Expand All @@ -128,21 +89,6 @@ jobs:
runner: ${{ needs.get-runner-labels.outputs.MACOS_RUNNER_LABELS }}
skipable: ${{ needs.check-changed.outputs.changed != 'true' }}

test-release-mac:
name: Test Release Mac
needs: [get-runner-labels]
if: contains(github.event.pull_request.title, '!macos')
uses: ./.github/workflows/reusable-build.yml
strategy:
fail-fast: false # Build and test everything so we can look at all the errors
matrix:
array:
- target: x86_64-apple-darwin
- target: aarch64-apple-darwin
with:
target: ${{ matrix.array.target }}
runner: ${{ needs.get-runner-labels.outputs.MACOS_RUNNER_LABELS }}

cargo-deny:
name: Check license of dependencies
runs-on: ubuntu-latest
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/reusable-build.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ on:
ref: # Git reference to checkout
required: false
type: string
env:
# Since CI builds are more akin to from-scratch builds, incremental compilation adds unnecessary dependency-tracking and IO overhead, reducing caching effectiveness.
# https://github.com/rust-lang/rust-analyzer/blob/25368d24308d6a94ffe8b99f0122bcf5a2175322/.github/workflows/ci.yaml#L11
CARGO_INCREMENTAL: 0

permissions:
# Allow commenting on issues
Expand Down Expand Up @@ -66,7 +70,6 @@ jobs:
if: ${{ !inputs.skipable }}
uses: ./.github/actions/rustup
with:
save-cache: ${{ github.ref_name == 'main' }} # This should be safe because we have nightly building the cache every day
shared-key: build-${{ inputs.target }}-${{ inputs.profile }}

- name: Trim paths
Expand Down

2 comments on commit b8488a5

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented on b8488a5 Feb 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ecosystem CI detail: Open

suite result
modernjs ✅ success
rspress ✅ success
rslib ✅ success
rsbuild ❌ failure
rsdoctor ❌ failure
examples ✅ success
devserver ✅ success
nuxt ✅ success

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented on b8488a5 Feb 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2025-02-14 05524cd) Current Change
10000_big_production-mode_disable-minimize + exec 37.9 s ± 263 ms 40 s ± 385 ms +5.59 %
10000_development-mode + exec 1.83 s ± 21 ms 1.87 s ± 9.6 ms +1.92 %
10000_development-mode_hmr + exec 680 ms ± 7.1 ms 696 ms ± 27 ms +2.37 %
10000_production-mode + exec 2.29 s ± 68 ms 2.32 s ± 58 ms +1.50 %
10000_production-mode_persistent-cold + exec 2.44 s ± 66 ms 2.49 s ± 134 ms +2.33 %
10000_production-mode_persistent-hot + exec 1.68 s ± 135 ms 1.68 s ± 33 ms -0.15 %
arco-pro_development-mode + exec 1.8 s ± 164 ms 1.8 s ± 205 ms +0.22 %
arco-pro_development-mode_hmr + exec 388 ms ± 1.9 ms 388 ms ± 3.1 ms -0.06 %
arco-pro_production-mode + exec 3.6 s ± 123 ms 3.67 s ± 173 ms +1.79 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.63 s ± 134 ms 3.72 s ± 187 ms +2.29 %
arco-pro_production-mode_persistent-cold + exec 3.79 s ± 176 ms 3.88 s ± 149 ms +2.37 %
arco-pro_production-mode_persistent-hot + exec 2.37 s ± 75 ms 2.39 s ± 97 ms +1.03 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.62 s ± 183 ms 3.7 s ± 228 ms +2.18 %
large-dyn-imports_development-mode + exec 2.12 s ± 18 ms 2.19 s ± 14 ms +3.46 %
large-dyn-imports_production-mode + exec 2.15 s ± 48 ms 2.18 s ± 47 ms +1.31 %
threejs_development-mode_10x + exec 1.58 s ± 69 ms 1.55 s ± 68 ms -1.91 %
threejs_development-mode_10x_hmr + exec 785 ms ± 7.9 ms 774 ms ± 13 ms -1.36 %
threejs_production-mode_10x + exec 5.25 s ± 50 ms 5.25 s ± 81 ms +0.14 %
threejs_production-mode_10x_persistent-cold + exec 5.31 s ± 95 ms 5.37 s ± 195 ms +1.12 %
threejs_production-mode_10x_persistent-hot + exec 4.52 s ± 102 ms 4.6 s ± 365 ms +1.65 %
10000_big_production-mode_disable-minimize + rss memory 8704 MiB ± 49.5 MiB 8721 MiB ± 116 MiB +0.20 %
10000_development-mode + rss memory 636 MiB ± 27.9 MiB 646 MiB ± 15.3 MiB +1.52 %
10000_development-mode_hmr + rss memory 1223 MiB ± 158 MiB 1278 MiB ± 274 MiB +4.51 %
10000_production-mode + rss memory 628 MiB ± 14.1 MiB 624 MiB ± 23.4 MiB -0.70 %
10000_production-mode_persistent-cold + rss memory 735 MiB ± 12.5 MiB 734 MiB ± 31.4 MiB -0.09 %
10000_production-mode_persistent-hot + rss memory 719 MiB ± 3.87 MiB 716 MiB ± 26.8 MiB -0.42 %
arco-pro_development-mode + rss memory 583 MiB ± 24.4 MiB 575 MiB ± 41 MiB -1.45 %
arco-pro_development-mode_hmr + rss memory 644 MiB ± 77 MiB 650 MiB ± 84.6 MiB +0.79 %
arco-pro_production-mode + rss memory 724 MiB ± 7.62 MiB 719 MiB ± 22.7 MiB -0.76 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 728 MiB ± 15.8 MiB 736 MiB ± 32.7 MiB +1.04 %
arco-pro_production-mode_persistent-cold + rss memory 843 MiB ± 21.6 MiB 844 MiB ± 27.4 MiB +0.08 %
arco-pro_production-mode_persistent-hot + rss memory 710 MiB ± 22.1 MiB 714 MiB ± 22.5 MiB +0.56 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 709 MiB ± 8.18 MiB 719 MiB ± 35.3 MiB +1.42 %
large-dyn-imports_development-mode + rss memory 643 MiB ± 3.77 MiB 640 MiB ± 3.65 MiB -0.47 %
large-dyn-imports_production-mode + rss memory 525 MiB ± 6.6 MiB 528 MiB ± 2.53 MiB +0.49 %
threejs_development-mode_10x + rss memory 552 MiB ± 18.3 MiB 555 MiB ± 9.6 MiB +0.49 %
threejs_development-mode_10x_hmr + rss memory 1105 MiB ± 90.1 MiB 1157 MiB ± 94.9 MiB +4.68 %
threejs_production-mode_10x + rss memory 841 MiB ± 33 MiB 830 MiB ± 45.1 MiB -1.30 %
threejs_production-mode_10x_persistent-cold + rss memory 968 MiB ± 36.3 MiB 940 MiB ± 64.6 MiB -2.91 %
threejs_production-mode_10x_persistent-hot + rss memory 866 MiB ± 43.1 MiB 851 MiB ± 44.3 MiB -1.77 %

Threshold exceeded: ["10000_big_production-mode_disable-minimize + exec"]

Please sign in to comment.