Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflow): no need to run pnpm cache in rust jobs #9430

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Feb 21, 2025

Summary

It seems we do not need to run pnpm cache in some Rust jobs. Remove this step should make these workflows 30s faster.

For example:

image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Feb 21, 2025
Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 2fc3c01
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67b83f9808dc480008e9ec36

@chenjiahan chenjiahan changed the title chore(workflow): no need to run pnpm cache in rust check chore(workflow): no need to run pnpm cache in rust jobs Feb 21, 2025
Copy link

codspeed-hq bot commented Feb 21, 2025

CodSpeed Performance Report

Merging #9430 will not alter performance

Comparing rust_check_ci_0221 (2fc3c01) with main (f7ec690)

Summary

✅ 7 untouched benchmarks

@stormslowly stormslowly merged commit 4965098 into main Feb 21, 2025
31 checks passed
@stormslowly stormslowly deleted the rust_check_ci_0221 branch February 21, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants