fix: rebuild ignore modules contain built-in loader errors

crates/rspack_core/src/normal_module.rs

@@ -447,6 +447,15 @@ impl Module for NormalModule {
           .with_stack(stack)
           .with_hide_stack(captured_error.hide_stack)
         } else {
+          self.build_info.cacheable = false;
+          if let Some(file_path) = &self.resource_data.resource_path {
+            if file_path.is_absolute() {
+              self
+                .build_info
+                .file_dependencies
+                .insert(file_path.clone().into_std_path_buf().into());
+            }
+          }
           let node_error = r.downcast_ref::<NodeError>();
           let stack = node_error.and_then(|e| e.stack.clone());
           let hide_stack = node_error.and_then(|e| e.hide_stack);

tests/e2e/cases/make/failed_module_by_builtin_loader/index.test.ts

@@ -0,0 +1,31 @@
+import { expect, test } from "@/fixtures";
+
+test("should compile", async ({ page, fileAction, rspack }) => {
+	await expect(page.getByText("index")).toBeVisible();
+
+	fileAction.updateFile("src/index.js", content =>
+		content.replace('div.innerText = "index";', 'div.innerText = "er;')
+	);
+
+	await page.reload();
+	await expect(page.locator("#webpack-dev-server-client-overlay")).toHaveCount(
+		1
+	);
+	let stats = rspack.compiler._lastCompilation
+		?.getStats()
+		.toJson({ all: false, errors: true });
+	expect(stats?.errors?.length).toBe(1);
+
+	fileAction.updateFile("src/index.js", content =>
+		content.replace('div.innerText = "er;', 'div.innerText = "index";')
+	);
+	await page.reload();
+	await expect(page.locator("#webpack-dev-server-client-overlay")).toHaveCount(
+		0
+	);
+	await expect(page.getByText("index")).toBeVisible();
+	stats = rspack.compiler._lastCompilation
+		?.getStats()
+		.toJson({ all: false, errors: true });
+	expect(stats?.errors?.length).toBe(0);
+});

tests/e2e/cases/make/failed_module_by_builtin_loader/rspack.config.js

@@ -0,0 +1,22 @@
+const rspack = require("@rspack/core");
+
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	entry: "./src/index.js",
+	context: __dirname,
+	mode: "development",
+	plugins: [new rspack.HtmlRspackPlugin()],
+	module: {
+		rules: [
+			{
+				test: /\.js$/,
+				exclude: [/node_modules/],
+				include: [/src/],
+				loader: "builtin:swc-loader"
+			}
+		]
+	},
+	devServer: {
+		hot: true
+	}
+};

tests/e2e/cases/make/failed_module_by_builtin_loader/src/index.js

@@ -0,0 +1,6 @@
+Promise.resolve().then(() => {
+	const div = document.createElement("div");
+	div.innerText = "index";
+	div.id = "index";
+	document.body.appendChild(div);
+});

tests/e2e/cases/make/failed_module_by_js_loader/index.test.ts

@@ -0,0 +1,31 @@
+import { expect, test } from "@/fixtures";
+
+test("should compile", async ({ page, fileAction, rspack }) => {
+	await expect(page.getByText("index")).toBeVisible();
+
+	fileAction.updateFile("src/index.js", content =>
+		content.replace('div.innerText = "index";', 'div.innerText = "error";')
+	);
+
+	await page.reload();
+	await expect(page.locator("#webpack-dev-server-client-overlay")).toHaveCount(
+		1
+	);
+	let stats = rspack.compiler._lastCompilation
+		?.getStats()
+		.toJson({ all: false, errors: true });
+	expect(stats?.errors?.length).toBe(1);
+
+	fileAction.updateFile("src/index.js", content =>
+		content.replace('div.innerText = "error";', 'div.innerText = "index";')
+	);
+	await page.reload();
+	await expect(page.locator("#webpack-dev-server-client-overlay")).toHaveCount(
+		0
+	);
+	await expect(page.getByText("index")).toBeVisible();
+	stats = rspack.compiler._lastCompilation
+		?.getStats()
+		.toJson({ all: false, errors: true });
+	expect(stats?.errors?.length).toBe(0);
+});

tests/e2e/cases/make/failed_module_by_js_loader/loader.js

@@ -0,0 +1,6 @@
+module.exports = function (content) {
+	if (content.includes("error")) {
+		throw new Error("loader transform error");
+	}
+	return content;
+};

tests/e2e/cases/make/failed_module_by_js_loader/rspack.config.js

@@ -0,0 +1,22 @@
+const rspack = require("@rspack/core");
+
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	entry: "./src/index.js",
+	context: __dirname,
+	mode: "development",
+	plugins: [new rspack.HtmlRspackPlugin()],
+	module: {
+		rules: [
+			{
+				test: /\.js$/,
+				exclude: [/node_modules/],
+				include: [/src/],
+				loader: "./loader.js"
+			}
+		]
+	},
+	devServer: {
+		hot: true
+	}
+};

tests/e2e/cases/make/failed_module_by_js_loader/src/index.js

@@ -0,0 +1,6 @@
+Promise.resolve().then(() => {
+	const div = document.createElement("div");
+	div.innerText = "index";
+	div.id = "index";
+	document.body.appendChild(div);
+});