Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rebuild ignore modules contain built-in loader errors #9482

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

jerrykingxyz
Copy link
Contributor

@jerrykingxyz jerrykingxyz commented Feb 26, 2025

Summary

Builtin loaders throw error will make normal module does not contains any file_dependencies and mark as cacheable, those modules will never rebuild forever with memory cache. This PR will mark those module as cacheable and set they resourcePath as file_dependencies.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Sorry, something went wrong.

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Feb 26, 2025
Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit c34e4e6
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67bfec5a0edb2a0008687dfd

Copy link

codspeed-hq bot commented Feb 26, 2025

CodSpeed Performance Report

Merging #9482 will not alter performance

Comparing jerry/make (c34e4e6) with main (3a60a03)

Summary

✅ 7 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants