Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yaml to update slot deployment creds + add exponential backoff to intermittently failing integration tests #906

Merged
merged 4 commits into from
May 26, 2020

Conversation

utsavized
Copy link
Contributor

No description provided.

@utsavized utsavized requested review from molant and antross May 26, 2020 18:05
@utsavized utsavized self-assigned this May 26, 2020
Disabling conditions to validate changes
@utsavized
Copy link
Contributor Author

@molant @antross This should be good to go.

@utsavized utsavized changed the title Update azure-pipelines.yml for Azure Pipelines Update yaml to update slot deployment creds + add exponential backoff to intermittently failing integration tests May 26, 2020
@utsavized utsavized added this to the 2005-2 milestone May 26, 2020
- bash: |
az login --service-principal -u $AZURE_SERVICE_PRINCIPAL -p $AZURE_SERVICE_PRINCIPAL_PASSWORD --tenant $AZURE_TENANT
az webapp deployment slot swap -g webhint-web -n sonarwhal --slot staging
- task: AzureAppServiceManage@0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Copy link
Member

@antross antross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making the tests more reliable too!

@utsavized utsavized merged commit b967b03 into master May 26, 2020
@utsavized utsavized deleted the azure-pipelines branch May 26, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Puppeteer integration tests during deployment are intermittently failing
3 participants