Fix STM32H5 update

[mattia-moffa]

Fix for STM32H5 update. ZD 20037

[dgarske]

Nice work!!

[dgarske]

I cannot get the update to work with DUALBANK 0 or 1. Can you share your steps to reproduce? I tried with trustzone and update would not take even. Without trustzone I couldn't get it to boot.

I also have had trouble getting XMODEM to work with mincom or CoolTerm. It never seems to finish. Would be curious how you are testing.

I even added a command to call wolfBoot_update_trigger(); manually after flashing a new version to the update partition. But it won't install.

I also tried using the "fake" method with:

./tools/keytools/sign --ecc256 test-app/image.bin wolfboot_signing_private_key.der 2
echo -n "pBOOT" > trigger_magic.bin
./tools/bin-assemble/bin-assemble \
  update.bin \
    0x0     test-app/image_v2_signed.bin \
    0x9DFFB trigger_magic.bin
STM32_Programmer_CLI -c port=swd -d update.bin 0x08100000

[mattia-moffa]

I'm using the default config/examples/stm32h5-tz.config.

I'm generating the images with:

make # or make DEBUG=1
IMAGE_HEADER_SIZE=1024 tools/keytools/sign --ecc256 --sha256 test-app/image.bin wolfboot_signing_private_key.der 2

(notice the IMAGE_HEADER_SIZE, that's important).

then flashing:

• wolfboot.bin to 0x0C000000
• test-app/image_v1_signed.bin to 0x08060000
• test-app/image_v2_signed.bin to 0x08100000

then writing pBOOT to the end of the update partition. Since the partition size is 0xA0000, that would be at offset 0x9FFFB in the partition, i.e. address 0x0819FFFB. You're using 0x9DFFB which I don't think is the right address (?)

It also works if I update via XMODEM in the app, but that's a bit unreliable on minicom on my end for whatever reason, I have to use CoolTerm.

[dgarske]

I'm using the default config/examples/stm32h5-tz.config.

I'm generating the images with:

make # or make DEBUG=1
IMAGE_HEADER_SIZE=1024 tools/keytools/sign --ecc256 --sha256 test-app/image.bin wolfboot_signing_private_key.der 2

(notice the IMAGE_HEADER_SIZE, that's important).

then flashing:

• wolfboot.bin to 0x0C000000
• test-app/image_v1_signed.bin to 0x08060000
• test-app/image_v2_signed.bin to 0x08100000

then writing pBOOT to the end of the update partition. Since the partition size is 0xA0000, that would be at offset 0x9FFFB in the partition, i.e. address 0x0819FFFB. You're using 0x9DFFB which I don't think is the right address (?)

It also works if I update via XMODEM in the app, but that's a bit unreliable on minicom on my end for whatever reason, I have to use CoolTerm.

Please update the targets.md with these details.

[dgarske]

@mattia-moffa please look into why the "update" -> XMODEM isn't working. Also please try using the new NSC functions for setting trigger_update and success. Thank you

[dgarske]

Approving and merging as is. This PR actually makes the update partition marked secure flash and uses the NCS callable interface to program the update partition, which is very nice. There is a known issue with Dual bank Mattia is working on and will followup with a new PR.