Hardening in wc_MakeDsaKey and wc_FreeDsaKey#9892
Merged
douzzer merged 4 commits intowolfSSL:masterfrom Mar 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens DSA key operations by using mp_forcezero (which zeroes memory before clearing) instead of mp_clear for sensitive private key material, and adds a ForceZero call on the temporary buffer used during key generation.
Changes:
wc_FreeDsaKey: Always callsmp_forcezeroon the private key componentx, removing the conditional check forDSA_PRIVATEwc_MakeDsaKey: Replacesmp_clearwithmp_forcezeroonxin the error path, and addsForceZero(cBuf, cSz)to clear the temporary buffer before freeing it
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Retest this please |
douzzer
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use force zero to harden DSA operations
Fixes
Checklist