Skip to content

Hardening in wc_MakeDsaKey and wc_FreeDsaKey #9892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
douzzer merged 4 commits into from
Mar 7, 2026
+3 −5
Merged

Hardening in wc_MakeDsaKey and wc_FreeDsaKey #9892

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
967aaa2
Fix F380 to harden wc_MakeDsaKey
embhorn Mar 5, 2026
f093268
Fix F381 to harden wc_MakeDsaKey
embhorn Mar 5, 2026
d638824
Fix F382 to harden wc_FreeDsaKey
embhorn Mar 5, 2026
355081b
Fix test with cast
embhorn Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions wolfcrypt/src/dsa.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,7 @@ void wc_FreeDsaKey(DsaKey* key)
if (key == NULL)
return;

if (key->type == DSA_PRIVATE)
mp_forcezero(&key->x);

mp_clear(&key->x);
mp_forcezero(&key->x);
mp_clear(&key->y);
mp_clear(&key->g);
mp_clear(&key->q);
Expand Down Expand Up @@ -227,10 +224,11 @@ int wc_MakeDsaKey(WC_RNG *rng, DsaKey *dsa)
dsa->type = DSA_PRIVATE;

if (err != MP_OKAY) {
mp_clear(&dsa->x);
mp_forcezero(&dsa->x);
mp_clear(&dsa->y);
}

ForceZero(cBuf, cSz);
#if defined(WOLFSSL_SMALL_STACK) && !defined(WOLFSSL_NO_MALLOC)
XFREE(cBuf, dsa->heap, DYNAMIC_TYPE_TMP_BUFFER);
if (tmpQ != NULL) {
Expand Down
Loading