Run the E2E Tests workflow on every pull request - #640
Conversation
E2E previously ran only around release branches, so the regressions it guards went unnoticed until release time. Trigger it for all pull requests (skipping documentation-only changes via paths-ignore) and for pushes to trunk as well. Pushes to release branches keep their trigger. Releases are built from the latest commit on the release branch, but a pull_request run does not test that commit; it tests a temporary merge commit that GitHub creates from the PR and its target branch. The push trigger is what tests the exact commit that will be released.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the E2E Tests GitHub Actions workflow so end-to-end tests run as a standard per-PR check (instead of only around release/**), with documentation-only changes excluded via paths-ignore. This improves earlier detection of regressions and adds a post-merge signal on trunk.
Changes:
- Expand
pull_requesttrigger to run on all PRs, while skipping doc-only changes viapaths-ignore. - Expand
pushtrigger to includetrunk(while keepingrelease/**) so merges and release-branch commits both get tested.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| branches: | ||
| - "release/**" | ||
| paths-ignore: | ||
| - "**.md" |
There was a problem hiding this comment.
The official Patterns to match file paths of GitHub Actions document the equivalent pattern '**.js' as "Matches all .js files in the repository", so '**.md' should be correct here.
Changes proposed in this Pull Request:
The E2E Tests workflow previously ran only for pushes and pull requests around
release/**branches, so the regressions it guards went unnoticed until release time. With the suite now at 85 tests and hardened for CI, this PR turns it into a per-PR check.Trigger changes:
pull_requestnow runs for every pull request, with apaths-ignorelist that skips documentation-only changes.pushnow also coverstrunkfor a post-merge signal.release/**keep their trigger. Releases are built from the latest commit on the release branch, but apull_requestrun does not test that commit; it tests a temporary merge commit that GitHub creates from the PR and its target branch. The push trigger is what tests the exact commit that will be released.Checks:
Detailed test instructions:
trunk.Changelog entry