Skip to content

Run the E2E Tests workflow on every pull request - #640

Merged
eason9487 merged 1 commit into
trunkfrom
dev/run-e2e-ci-on-all-prs
Jul 24, 2026
Merged

Run the E2E Tests workflow on every pull request#640
eason9487 merged 1 commit into
trunkfrom
dev/run-e2e-ci-on-all-prs

Conversation

@eason9487

Copy link
Copy Markdown
Member

Changes proposed in this Pull Request:

The E2E Tests workflow previously ran only for pushes and pull requests around release/** branches, so the regressions it guards went unnoticed until release time. With the suite now at 85 tests and hardened for CI, this PR turns it into a per-PR check.

Trigger changes:

  • pull_request now runs for every pull request, with a paths-ignore list that skips documentation-only changes.
  • push now also covers trunk for a post-merge signal.
  • Pushes to release/** keep their trigger. Releases are built from the latest commit on the release branch, but a pull_request run does not test that commit; it tests a temporary merge commit that GitHub creates from the PR and its target branch. The push trigger is what tests the exact commit that will be released.

Checks:

  • Does your code follow the WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Detailed test instructions:

  1. Confirm the E2E Tests workflow is triggered on this pull request itself.
  2. Confirm the E2E Tests workflow run passes.
  3. After merging, confirm the workflow also runs on the push to trunk.

Changelog entry

E2E previously ran only around release branches, so the regressions it
guards went unnoticed until release time. Trigger it for all pull
requests (skipping documentation-only changes via paths-ignore) and for
pushes to trunk as well.

Pushes to release branches keep their trigger. Releases are built from
the latest commit on the release branch, but a pull_request run does not
test that commit; it tests a temporary merge commit that GitHub creates
from the PR and its target branch. The push trigger is what tests the
exact commit that will be released.
@eason9487 eason9487 self-assigned this Jul 24, 2026
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • .github/workflows/e2e-tests.yml is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 36256446-b12a-4af1-9cff-158cfd37e30c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev/run-e2e-ci-on-all-prs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the changelog: dev Developer-facing only change. label Jul 24, 2026
@eason9487
eason9487 requested a review from Copilot July 24, 2026 08:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the E2E Tests GitHub Actions workflow so end-to-end tests run as a standard per-PR check (instead of only around release/**), with documentation-only changes excluded via paths-ignore. This improves earlier detection of regressions and adds a post-merge signal on trunk.

Changes:

  • Expand pull_request trigger to run on all PRs, while skipping doc-only changes via paths-ignore.
  • Expand push trigger to include trunk (while keeping release/**) so merges and release-branch commits both get tested.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

branches:
- "release/**"
paths-ignore:
- "**.md"

@eason9487 eason9487 Jul 24, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The official Patterns to match file paths of GitHub Actions document the equivalent pattern '**.js' as "Matches all .js files in the repository", so '**.md' should be correct here.

image

@eason9487
eason9487 merged commit b62e72d into trunk Jul 24, 2026
6 checks passed
@eason9487
eason9487 deleted the dev/run-e2e-ci-on-all-prs branch July 24, 2026 08:17
@costasovo costasovo mentioned this pull request Aug 6, 2026
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: dev Developer-facing only change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants