Skip to content

Update Reader bundle id and add keychain access group #24478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 22, 2025
Merged

Update Reader bundle id and add keychain access group #24478

merged 5 commits into from
Apr 22, 2025

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Apr 17, 2025

@mokagio mokagio added this to the 25.9 milestone Apr 17, 2025
@mokagio mokagio added the Tooling Build, Release, and Validation Tools label Apr 17, 2025
@mokagio mokagio self-assigned this Apr 17, 2025
@mokagio mokagio requested review from kean and crazytonyli April 17, 2025 22:31
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 17, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number27450
VersionPR #24478
Bundle IDorg.wordpress.alpha
Commit3ba04d8
Installation URL3ikcn31sree9g
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 17, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number27450
VersionPR #24478
Bundle IDcom.jetpack.alpha
Commit3ba04d8
Installation URL6d120v8ovbhko
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio
Copy link
Contributor Author

mokagio commented Apr 22, 2025

The failed TestFlight upload has to do with missing privacy descriptions, at least NSPhotoLibraryUsageDescription.

It's surprising that 4d7578f did not include this key while also being successfully distributed to TestFlight...

@dangermattic
Copy link
Collaborator

dangermattic commented Apr 22, 2025 •
edited
Loading

1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@mokagio
Copy link
Contributor Author

mokagio commented Apr 22, 2025 •
edited
Loading

576f8d4 addressed the TestFlight processing issue

IMG_808397CE6B66-1

Just waiting for #24471 to land, given it's already in the merge queue, so I can update the base branch.

Base automatically changed from mokagio/reader-secerts-and-config-update to trunk April 22, 2025 05:51
@mokagio mokagio force-pushed the mokagio/fix-reader-keychain-access branch from 576f8d4 to 3ba04d8 Compare April 22, 2025 11:03
@mokagio mokagio enabled auto-merge April 22, 2025 11:04
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mokagio mokagio mentioned this pull request Apr 22, 2025
Merged
@mokagio mokagio added this pull request to the merge queue Apr 22, 2025
Merged via the queue into trunk with commit 8618b81 Apr 22, 2025
32 of 34 checks passed
@mokagio mokagio deleted the mokagio/fix-reader-keychain-access branch April 22, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kean kean kean approved these changes

@crazytonyli crazytonyli Awaiting requested review from crazytonyli

Assignees

@mokagio mokagio

Labels
Tooling Build, Release, and Validation Tools
Projects
None yet
Milestone
25.9
Development

Successfully merging this pull request may close these issues.
4 participants
@mokagio @wpmobilebot @dangermattic @kean