Skip to content

Update Reader bundle id and add keychain access group #24478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Reader/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<key>WPExplatPlatform</key>
<string>wpios</string>
<key>WPItunesAppID</key>
<string>1565481562</string>
<string>6744776413</string>
<key>WPJetpackAppURLScheme</key>
<string>${WP_JETPACK_APP_URL_SCHEME}</string>
<key>WPMobileAnnounceAppID</key>
Expand Down
4 changes: 4 additions & 0 deletions Sources/Reader/Reader.entitlements
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,9 @@
<array>
<string>group.org.wordpress</string>
</array>
<key>keychain-access-groups</key>
<array>
<string>3TMU3BH3NK.org.wordpress</string>
</array>
</dict>
</plist>
6 changes: 3 additions & 3 deletions WordPress/WordPress.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -3982,6 +3982,7 @@
INFOPLIST_KEY_ITSAppUsesNonExemptEncryption = NO;
INFOPLIST_KEY_NSCameraUsageDescription = "To take photos or videos to use in your posts.";
INFOPLIST_KEY_NSMicrophoneUsageDescription = "Enable microphone access to record sound in your videos.";
INFOPLIST_KEY_NSPhotoLibraryUsageDescription = "To add photos or videos to your posts.";
INFOPLIST_KEY_UILaunchStoryboardName = LaunchScreen;
INFOPLIST_KEY_UISupportedInterfaceOrientations = "UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight UIInterfaceOrientationPortrait";
INFOPLIST_KEY_UISupportedInterfaceOrientations_iPad = "UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight UIInterfaceOrientationPortrait UIInterfaceOrientationPortraitUpsideDown";
Expand All @@ -3992,7 +3993,6 @@
MARKETING_VERSION = "${VERSION_SHORT}";
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
MTL_FAST_MATH = YES;
PRODUCT_BUNDLE_IDENTIFIER = com.automattic.reader;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_ACTIVE_COMPILATION_CONDITIONS = "DEBUG $(inherited)";
SWIFT_TREAT_WARNINGS_AS_ERRORS = NO;
Expand Down Expand Up @@ -4030,6 +4030,7 @@
INFOPLIST_KEY_ITSAppUsesNonExemptEncryption = NO;
INFOPLIST_KEY_NSCameraUsageDescription = "To take photos or videos to use in your posts.";
INFOPLIST_KEY_NSMicrophoneUsageDescription = "Enable microphone access to record sound in your videos.";
INFOPLIST_KEY_NSPhotoLibraryUsageDescription = "To add photos or videos to your posts.";
INFOPLIST_KEY_UILaunchStoryboardName = LaunchScreen;
INFOPLIST_KEY_UISupportedInterfaceOrientations = "UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight UIInterfaceOrientationPortrait";
INFOPLIST_KEY_UISupportedInterfaceOrientations_iPad = "UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight UIInterfaceOrientationPortrait UIInterfaceOrientationPortraitUpsideDown";
Expand All @@ -4040,7 +4041,6 @@
MARKETING_VERSION = "${VERSION_SHORT}";
MTL_ENABLE_DEBUG_INFO = NO;
MTL_FAST_MATH = YES;
PRODUCT_BUNDLE_IDENTIFIER = com.automattic.reader;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_TREAT_WARNINGS_AS_ERRORS = NO;
SWIFT_VERSION = 5.0;
Expand Down Expand Up @@ -4077,6 +4077,7 @@
INFOPLIST_KEY_ITSAppUsesNonExemptEncryption = NO;
INFOPLIST_KEY_NSCameraUsageDescription = "To take photos or videos to use in your posts.";
INFOPLIST_KEY_NSMicrophoneUsageDescription = "Enable microphone access to record sound in your videos.";
INFOPLIST_KEY_NSPhotoLibraryUsageDescription = "To add photos or videos to your posts.";
INFOPLIST_KEY_UILaunchStoryboardName = LaunchScreen;
INFOPLIST_KEY_UISupportedInterfaceOrientations = "UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight UIInterfaceOrientationPortrait";
INFOPLIST_KEY_UISupportedInterfaceOrientations_iPad = "UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight UIInterfaceOrientationPortrait UIInterfaceOrientationPortraitUpsideDown";
Expand All @@ -4087,7 +4088,6 @@
MARKETING_VERSION = "${VERSION_SHORT}";
MTL_ENABLE_DEBUG_INFO = NO;
MTL_FAST_MATH = YES;
PRODUCT_BUNDLE_IDENTIFIER = com.automattic.reader;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_TREAT_WARNINGS_AS_ERRORS = NO;
SWIFT_VERSION = 5.0;
Expand Down
2 changes: 2 additions & 0 deletions config/Reader.alpha.xcconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#include "Common.alpha.xcconfig"
#include "Version.public.xcconfig"

PRODUCT_BUNDLE_IDENTIFIER = com.automattic.readerapp

WP_PUSH_NOTIFICATION_APP_ID = TBD
WP_BUILD_CONFIGURATION = alpha
WP_APP_URL_SCHEME = wpreader
Expand Down
2 changes: 2 additions & 0 deletions config/Reader.debug.xcconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#include "Common.debug.xcconfig"
#include "Version.public.xcconfig"

PRODUCT_BUNDLE_IDENTIFIER = com.automattic.readerapp

WP_PUSH_NOTIFICATION_APP_ID = TBD
WP_BUILD_CONFIGURATION = debug
WP_APP_URL_SCHEME = wpreader
Expand Down
2 changes: 2 additions & 0 deletions config/Reader.release.xcconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#include "Common.release.xcconfig"
#include "Version.public.xcconfig"

PRODUCT_BUNDLE_IDENTIFIER = com.automattic.readerapp

WP_PUSH_NOTIFICATION_APP_ID = TBD
WP_BUILD_CONFIGURATION = release
WP_APP_URL_SCHEME = wpreader
Expand Down
2 changes: 1 addition & 1 deletion fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ JETPACK_EXTENSIONS_BUNDLE_IDENTIFIERS = %w[
].map { |suffix| "#{JETPACK_BUNDLE_IDENTIFIER}.#{suffix}" }
ALL_JETPACK_BUNDLE_IDENTIFIERS = [JETPACK_BUNDLE_IDENTIFIER, *JETPACK_EXTENSIONS_BUNDLE_IDENTIFIERS].freeze

READER_BUNDLE_IDENTIFIER = 'com.automattic.reader'
READER_BUNDLE_IDENTIFIER = 'com.automattic.readerapp'
# Redundant but handy for consistency, especially in codesign.rb
ALL_READER_BUNDLE_IDENTIFIERS = [READER_BUNDLE_IDENTIFIER].freeze

Expand Down