Skip to content

Conversation

@OmegaHelix
Copy link

Cleans up physical stats from Warlock UI and removes PseudoStatCastSpeedMultiplier ep that breaks stat weight calc modal.

Stat.StatSpellDamage,
Stat.StatSpellHit,
Stat.StatSpellCrit,
Stat.StatSpellHaste,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Haste" can stay in I believe as other classes also show it? But iirc this is not even a classic stat?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we actually show it in the "Classic" codebase looking around at other sims. In SoD we use the cast speed multiplier in place of StatSpellHaste since that stat is effectively ueless when summed up, but in vanilla there wasn't any gear with cast speed modifiers to my knowledge

Stat.StatShadowPower,
Stat.StatMP5,
],
epPseudoStats: [PseudoStat.PseudoStatCastSpeedMultiplier],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm this should work correctly. This is also what we use in SoD to provide the cast speed multiplier (effectively haste that functions differently because haste isn't in classic)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh but you know what cast speed isn't on vanilla gear so that's actually fine

@kayla-glick kayla-glick merged commit e8b6adf into wowsims:master Apr 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants