Skip to content

Update Warlock EP/Display stats #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kayla-glick merged 1 commit into from
Apr 6, 2025
Merged

Update Warlock EP/Display stats #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 3 additions & 20 deletions ui/warlock/sim.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,44 +18,30 @@ const SPEC_CONFIG = registerSpecConfig(Spec.SpecWarlock, {
// All stats for which EP should be calculated.
epStats: [
// Primary
Stat.StatHealth,
Stat.StatMana,
// Attributes
Stat.StatStrength,
Stat.StatStamina,
Stat.StatIntellect,
Stat.StatSpirit,
Stat.StatAgility,
// Physical
Stat.StatAttackPower,
Stat.StatMeleeCrit,
Stat.StatMeleeHit,
// Spell
Stat.StatSpellPower,
Stat.StatSpellDamage,
Stat.StatSpellHit,
Stat.StatSpellCrit,
Stat.StatSpellHaste,
Copy link
Contributor

@1337LutZ 1337LutZ Apr 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Haste" can stay in I believe as other classes also show it? But iirc this is not even a classic stat?

Copy link
Contributor

@kayla-glick kayla-glick Apr 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we actually show it in the "Classic" codebase looking around at other sims. In SoD we use the cast speed multiplier in place of StatSpellHaste since that stat is effectively ueless when summed up, but in vanilla there wasn't any gear with cast speed modifiers to my knowledge

Stat.StatFirePower,
Stat.StatShadowPower,
Stat.StatMP5,
],
epPseudoStats: [PseudoStat.PseudoStatCastSpeedMultiplier],
Copy link
Contributor

@kayla-glick kayla-glick Apr 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm this should work correctly. This is also what we use in SoD to provide the cast speed multiplier (effectively haste that functions differently because haste isn't in classic)

Copy link
Contributor

@kayla-glick kayla-glick Apr 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh but you know what cast speed isn't on vanilla gear so that's actually fine

epPseudoStats: [],
// Reference stat against which to calculate EP. DPS classes use either spell power or attack power.
epReferenceStat: Stat.StatSpellPower,
// Which stats to display in the Character Stats section, at the bottom of the left-hand sidebar.
displayStats: [
// Primary
Stat.StatHealth,
Stat.StatMana,
// Attributes
Stat.StatStrength,
Stat.StatAgility,
Stat.StatIntellect,
Stat.StatSpirit,
// Physical
Stat.StatAttackPower,
Stat.StatMeleeCrit,
Stat.StatMeleeHit,
// Spell
Stat.StatSpellPower,
Stat.StatSpellDamage,
Expand All @@ -65,7 +51,7 @@ const SPEC_CONFIG = registerSpecConfig(Spec.SpecWarlock, {
Stat.StatSpellCrit,
Stat.StatMP5,
],
displayPseudoStats: [PseudoStat.PseudoStatCastSpeedMultiplier],
displayPseudoStats: [],

defaults: {
// Default equipped gear.
Expand All @@ -88,9 +74,6 @@ const SPEC_CONFIG = registerSpecConfig(Spec.SpecWarlock, {
[Stat.StatStamina]: 0.01,
[Stat.StatFireResistance]: 0.0,
},
{
[PseudoStat.PseudoStatCastSpeedMultiplier]: 7.83,
},
),
// Default consumes settings.
consumes: Presets.DefaultConsumes,
Expand Down
Loading