Starshards and talents fix #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dot portion of Starshards
Lesser Arcane Elixir doesn't exist on Era/Fresh
fixed Force of Will and Searing Light multipliers
kayla-glick
reviewed
Apr 19, 2025
| priest.OnSpellRegistered(func(spell *core.Spell) { | ||
| if spell.Flags.Matches(SpellFlagPriest) { | ||
| spell.DamageMultiplier *= .01 * float64(priest.Talents.ForceOfWill) | ||
| spell.DamageMultiplier *= 1.01 * float64(priest.Talents.ForceOfWill) |
Contributor
There was a problem hiding this comment.
These talents should actually be applied to the additive multiplier because they use the Modifies Damage/Healing Done effect https://www.wowhead.com/classic/spell=18550/force-of-will but I can do a fast follow to update them because I'm sure a bunch are wrong in the classic code from being dated
kayla-glick
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least that's what I hope it does.. xP