Skip to content

Starshards and talents fix #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kayla-glick merged 3 commits into from
Apr 19, 2025
Merged

Starshards and talents fix #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
415ae69
Update starshards.go
Zephryl87 Apr 11, 2025
d408c51
Update consumables.ts
Zephryl87 Apr 15, 2025
675289f
Update talents.go
Zephryl87 Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sim/priest/starshards.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ func (priest *Priest) newStarshardsSpellConfig(rank int, tickIdx int32) core.Spe

ApplyEffects: func(sim *core.Simulation, target *core.Unit, spell *core.Spell) {
result := spell.CalcOutcome(sim, target, spell.OutcomeMagicHit)
if result.Landed() {
spell.Dot(target).Apply(sim)
}
spell.DealOutcome(sim, result)
},

Expand Down
4 changes: 2 additions & 2 deletions sim/priest/talents.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func (priest *Priest) applyForceOfWill() {

priest.OnSpellRegistered(func(spell *core.Spell) {
if spell.Flags.Matches(SpellFlagPriest) {
spell.DamageMultiplier *= .01 * float64(priest.Talents.ForceOfWill)
spell.DamageMultiplier *= 1.01 * float64(priest.Talents.ForceOfWill)
Copy link
Contributor

@kayla-glick kayla-glick Apr 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These talents should actually be applied to the additive multiplier because they use the Modifies Damage/Healing Done effect https://www.wowhead.com/classic/spell=18550/force-of-will but I can do a fast follow to update them because I'm sure a bunch are wrong in the classic code from being dated

spell.BonusCritRating += 1 * float64(priest.Talents.ForceOfWill) * core.CritRatingPerCritChance
}
})
Expand Down Expand Up @@ -120,7 +120,7 @@ func (priest *Priest) applySearingLight() {

priest.OnSpellRegistered(func(spell *core.Spell) {
if spell.SpellCode == SpellCode_PriestSmite || spell.SpellCode == SpellCode_PriestHolyFire {
spell.DamageMultiplier *= 0.05 * float64(priest.Talents.SearingLight)
spell.DamageMultiplier *= 1.05 * float64(priest.Talents.SearingLight)
}
})
}
Expand Down
5 changes: 0 additions & 5 deletions ui/core/components/inputs/consumables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,15 +738,10 @@ export const ArcaneElixir: ConsumableInputConfig<SpellPowerBuff> = {
actionId: () => ActionId.fromItemId(9155),
value: SpellPowerBuff.ArcaneElixir,
};
export const LesserArcaneElixir: ConsumableInputConfig<SpellPowerBuff> = {
actionId: () => ActionId.fromItemId(217398),
value: SpellPowerBuff.LesserArcaneElixir,
};

export const SPELL_POWER_CONFIG: ConsumableStatOption<SpellPowerBuff>[] = [
{ config: GreaterArcaneElixir, stats: [Stat.StatSpellPower] },
{ config: ArcaneElixir, stats: [Stat.StatSpellPower] },
{ config: LesserArcaneElixir, stats: [Stat.StatSpellPower] },
];

export const makeSpellPowerConsumeInput = makeConsumeInputFactory({ consumesFieldName: 'spellPowerBuff' });
Expand Down
Loading