Skip to content

Conversation

@InDebt
Copy link

@InDebt InDebt commented May 15, 2025

Removes the dependency on wowhead_tooltips.go

It seems we have not run the atlaas loot generation for a long time as for local testing I had to add lots of difficulty mappings we have not yet added in cata for Twilight dungeons and so forth. however this is now a 1:1 replacement of the old functionality and we would need new mappings for MoP anyways I suppose.

Copy link

@NerdEgghead NerdEgghead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you PR this into Cata as well please, so that we have validation via the diff on the generated db.json ?

@InDebt
Copy link
Author

InDebt commented May 16, 2025

Can you PR this into Cata as well please, so that we have validation via the diff on the generated db.json ?

Yes will do that later after work and check before.
Do you have a pref what we'll do with the new difficulties we probably have not yet accounted for (the HC+), I was thinking of just ignoring them for the PR and skipping to only get the zone diff as cata will be gone in a couple weeks, or should we properly add them for i.E the chinese realm that will move from Wotlk to cata most likely?

@NerdEgghead
Copy link

Can you PR this into Cata as well please, so that we have validation via the diff on the generated db.json ?

Yes will do that later after work and check before. Do you have a pref what we'll do with the new difficulties we probably have not yet accounted for (the HC+), I was thinking of just ignoring them for the PR and skipping to only get the zone diff as cata will be gone in a couple weeks, or should we properly add them for i.E the chinese realm that will move from Wotlk to cata most likely?

Ignoring them and just putting in a minimal implementation is totally fine, I mostly just want the two codebases in sync since we have proper testing in the Cata version.

@InDebt
Copy link
Author

InDebt commented May 16, 2025

wowsims#1493 created - while there are some chnages due to AtlasLoot being udpated, all the zones remain the same

@InDebt InDebt merged commit 63bb1c0 into wowsims:master May 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants