BUGFIX - Sebacious Poison Applied In Settings > Debuffs Counts Towards P8 Rogue DPS Tier 2pc Bonus #1438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ied by the sim in Settings UI or not
…ps tier 2pc bonus that will check whether the aura was added in Settings before adding stacks
Puddingstomp
changed the title
Collaborator
|
Got an alternate fix in place for this. I basically wrapped the poisons that could be applied via settings in a wrapper aura and adjusted the counts in the wrapper instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP but I am attempting to add a new callback to Auras to differentiate whether or not they "come from" the Settings UI in the sim. This should fix the interaction where if Sebacious Poison is turned on in Settings > Debuffs, it counts towards the Rogue P8 DPS Tier 2pc bonus when it shouldn't.
This has some ramifications when it does get fixed, as the SSL APL that Comfy currently has set up is relying on this bug to make the "pk swap macro" work.