Skip to content

BUGFIX - Sebacious Poison Applied In Settings > Debuffs Counts Towards P8 Rogue DPS Tier 2pc Bonus #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Puddingstomp wants to merge 3 commits into from
Closed

BUGFIX - Sebacious Poison Applied In Settings > Debuffs Counts Towards P8 Rogue DPS Tier 2pc Bonus #1438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d95501
initial commit
Puddingstomp Apr 4, 2025
d9e51dc
added a new callback to Auras to differentiate if they are being appl…
Puddingstomp Apr 4, 2025
22c8005
added if statement to the helper function that tracks stacks for p8 d…
Puddingstomp Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sim/core/aura.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,9 @@ type Aura struct {
metrics AuraMetrics

initialized bool

// P8 Sebacious Poison fix
IsEnabledInSettings bool
}

func (aura *Aura) init(sim *Simulation) {
Expand Down Expand Up @@ -439,6 +442,13 @@ func (aura *Aura) ApplyOnPeriodicDamageDealt(newOnPeriodicDamageDealt OnPeriodic
return aura
}

// TODO: working on fixing p8 bonus applying to Sebacious in Settings>Debuffs
func (aura *Aura) ApplyIsEnabledInSettings() *Aura {
aura.IsEnabledInSettings = true

return aura
}

type AuraFactory func(*Simulation) *Aura

// Callback for doing something on reset.
Expand Down
1 change: 1 addition & 0 deletions sim/core/debuffs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ func applyDebuffEffects(target *Unit, targetIdx int, debuffs *proto.Debuffs, lev

if debuffs.SebaciousPoison != proto.TristateEffect_TristateEffectMissing {
aura := SebaciousPoisonAura(target, TernaryInt32(debuffs.SebaciousPoison == proto.TristateEffect_TristateEffectRegular, 0, 2), level)
aura.ApplyIsEnabledInSettings()
SchedulePeriodicDebuffApplication(aura, PeriodicActionOptions{
Period: time.Second * 0,
NumTicks: 1,
Expand Down
2 changes: 2 additions & 0 deletions sim/rogue/item_sets_phase_8.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package rogue

import (
"fmt"
"time"

"github.com/wowsims/sod/sim/core"
Expand Down Expand Up @@ -54,6 +55,7 @@ func (rogue *Rogue) applyScarletEnclaveDamage2PBonus() {
Handler: func(sim *core.Simulation, spell *core.Spell, result *core.SpellResult) {
totalBleedsAndPoisons := rogue.PoisonsActive[rogue.CurrentTarget.UnitIndex] + rogue.BleedsActive[rogue.CurrentTarget.UnitIndex]

fmt.Println("Stack Count: ", totalBleedsAndPoisons)
// Only apply the damage mod up to 3 times for the 60% bonus maximum
damageMod.UpdateFloatValue(1 + 0.20*float64(min(3, totalBleedsAndPoisons)))
damageMod.Activate()
Expand Down
14 changes: 9 additions & 5 deletions sim/rogue/poisons.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package rogue

import (
"fmt"
"strconv"
"time"

Expand Down Expand Up @@ -69,11 +70,14 @@ func (rogue *Rogue) improvedPoisonsBonusProcChance() float64 {

// p8 DPS tier bonus helper function
func trackTotalUniquePoisons(aura *core.Aura, rogue *Rogue) {
aura.ApplyOnGain(func(aura *core.Aura, sim *core.Simulation) {
rogue.PoisonsActive[aura.Unit.UnitIndex]++
}).ApplyOnExpire(func(aura *core.Aura, sim *core.Simulation) {
rogue.PoisonsActive[aura.Unit.UnitIndex]--
})
fmt.Println("AuraIsFromSettings: ", aura.IsEnabledInSettings)
if !aura.IsEnabledInSettings {
aura.ApplyOnGain(func(aura *core.Aura, sim *core.Simulation) {
rogue.PoisonsActive[aura.Unit.UnitIndex]++
}).ApplyOnExpire(func(aura *core.Aura, sim *core.Simulation) {
rogue.PoisonsActive[aura.Unit.UnitIndex]--
})
}
}

///////////////////////////////////////////////////////////////////////////
Expand Down
Loading