fixing/cleaning up hunter talents #1441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayla-glick
commented
Apr 5, 2025
Comment on lines
+84
to
+86
| Kind: core.SpellMod_DamageDone_Pct, | ||
| ClassMask: ClassSpellMask_HunterRaptorStrike | ClassSpellMask_HunterRaptorStrikeHit | ClassSpellMask_HunterWyvernStrike, | ||
| FloatValue: 1.20, |
Collaborator
Author
There was a problem hiding this comment.
Found to be pct not flat
kayla-glick
commented
Apr 5, 2025
|
|
||
| CritDamageBonus: hunter.mortalShots(), | ||
|
|
||
| DamageMultiplier: 1 + .05*float64(hunter.Talents.Barrage), |
Collaborator
Author
There was a problem hiding this comment.
Applied incorrectly. Moved to flat mod in talents.go
kayla-glick
commented
Apr 5, 2025
| return hunter.DefensiveState.IsActive() | ||
| }, | ||
|
|
||
| BonusCritRating: float64(hunter.Talents.SavageStrikes) * 10 * core.CritRatingPerCritChance, |
Collaborator
Author
There was a problem hiding this comment.
Moved to talents.go
kayla-glick
commented
Apr 5, 2025
| IgnoreHaste: true, | ||
| CD: core.Cooldown{ | ||
| Timer: timer, | ||
| Duration: time.Second*6 - time.Millisecond*200*time.Duration(hunter.Talents.ImprovedArcaneShot), |
Collaborator
Author
There was a problem hiding this comment.
Moved to talents.go
kayla-glick
commented
Apr 5, 2025
| ProcMask: procMask, | ||
| Flags: core.SpellFlagMeleeMetrics | core.SpellFlagNoOnCastComplete, | ||
|
|
||
| BonusCritRating: float64(hunter.Talents.SavageStrikes) * 10 * core.CritRatingPerCritChance, |
Collaborator
Author
There was a problem hiding this comment.
Moved to talents.go
kayla-glick
commented
Apr 5, 2025
|
|
||
| hasImprovedVolley := hunter.HasRune(proto.HunterRune_RuneCloakImprovedVolley) | ||
|
|
||
| manaCostModifer := 100 - 2*hunter.Talents.Efficiency |
Collaborator
Author
There was a problem hiding this comment.
Moved to talents.go
kayla-glick
commented
Apr 5, 2025
| }, | ||
| }, | ||
|
|
||
| CritDamageBonus: (1 + hunter.mortalShots()) * (1 + (0.05 * float64(hunter.Talents.Barrage))), |
Collaborator
Author
There was a problem hiding this comment.
Applied incorrectly. Fixed in talents.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.