Skip to content

fixing/cleaning up hunter talents #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kayla-glick merged 3 commits into from
Apr 6, 2025
Merged

fixing/cleaning up hunter talents #1441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c6d509
fixing/cleaning up hunter talents
kayla-glick Apr 5, 2025
b2ec840
surefooted should not add spell hit
kayla-glick Apr 5, 2025
8c8fdf4
update chimera serpent calculation
kayla-glick Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sim/core/spell_mod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ const (
// Uses FloatValue
SpellMod_CritDamageBonus_Flat

// Will reduce spell.DefaultCast.Cost by % amount. -5% = -0.05
// Will reduce spell.DefaultCast.Cost by % amount. -5% = -5
// Uses IntValue
SpellMod_PowerCost_Pct

Expand Down
2 changes: 1 addition & 1 deletion sim/hunter/arcane_shot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func (hunter *Hunter) getArcaneShotConfig(rank int, timer *core.Timer) core.Spel
IgnoreHaste: true,
CD: core.Cooldown{
Timer: timer,
Duration: time.Second*6 - time.Millisecond*200*time.Duration(hunter.Talents.ImprovedArcaneShot),
Copy link
Collaborator Author

@kayla-glick kayla-glick Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to talents.go

Duration: time.Second * 6,
},
},

Expand Down
Loading
Loading