Skip to content

refactor: make vite a default peer #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: major
Choose a base branch
from
Open

refactor: make vite a default peer #1945

wants to merge 1 commit into from
+3 −0

Conversation

@lishaduck
Copy link
Contributor

Overview

I think this could be breaking in theory, but...

  • If you're using the default setup, you're already good.
  • If you've customized your Vite version, you probably thought it was a peer.

Manual Testing

Make some projects and ensure the correct versions are installed.

Related Issue

This PR closes #1631

@netlify
Copy link

netlify bot commented Oct 22, 2025 •
edited
Loading

✅ Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 0f430b4
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/68fc37cf7f44e500087cac0c
😎 Deploy Preview https://deploy-preview-1945--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

This was referenced Oct 22, 2025
Open
Open
@aklinker1 aklinker1 changed the base branch from main to major October 25, 2025 02:30
@aklinker1 aklinker1 changed the base branch from major to main October 25, 2025 02:30
@aklinker1
Copy link
Member

Could you rebase this off of major instead of main? This is a breaking change, and that's where I stage all breaking changes before the next major release.

@lishaduck
refactor: make vite a default peer
0f430b4 
I think this could be breaking in theory, but...
- If you're using the default setup, you're already good.
- If you've customized your Vite version, you probably thought it was a peer.
@lishaduck
Copy link
Contributor Author

Could you rebase this off of major instead of main? This is a breaking change, and that's where I stage all breaking changes before the next major release.

Rebased! (fyi, would probably be good for major to get updated from main, it's pretty far back right now)

@lishaduck lishaduck changed the base branch from main to major October 25, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aklinker1 aklinker1 Awaiting requested review from aklinker1 aklinker1 is a code owner

@Timeraa Timeraa Awaiting requested review from Timeraa Timeraa is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make Vite a Peer Dependency

2 participants

@lishaduck @aklinker1