[WIP] push/pop reset happens twice for cdc fifos#952
Draft
masai-openai wants to merge 5 commits intomainfrom
Draft
[WIP] push/pop reset happens twice for cdc fifos#952masai-openai wants to merge 5 commits intomainfrom
masai-openai wants to merge 5 commits intomainfrom
Conversation
masai-openai
force-pushed
the
masai/cdc
branch
from
08c6431 to
ee12a14
Compare
masai-openai
changed the title
masai-openai
changed the title
zhemao-openai
approved these changes
Jan 16, 2026
|
|
||
| br_verilog_fpv_test_tools_suite( | ||
| name = "br_cdc_fifo_ctrl_1r1w_test_suite", | ||
| gui = True, |
Contributor
There was a problem hiding this comment.
Remove this line before submission
Contributor
|
Is this ready for review? Tagged as WIP, but not in draft. |
masai-openai
force-pushed
the
masai/cdc
branch
from
350c8ef to
d76581f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once FPV test is out of reset, FV usually doesn't go into reset again.
However, due to RTL bug #948, adding this change so push_rst and pop_rst would reset twice.
bazel test //cdc/fpv:br_cdc_fifo_ctrl_1r1w_test_suite_jg_d2_nss3_rrl0_rwl3_rpo0_w1_fpv_test --test_env=DISPLAY=$DISPLAY --test_timeout=18000
assertion to debug:
::br_cdc_fifo_ctrl_1r1w_fpv_monitor.dut.br_cdc_fifo_ctrl_push_1r1w.br_cdc_fifo_push_ctrl.slots_in_range_a