FPV bench setup for br_cdc_stable_data#998
FPV bench setup for br_cdc_stable_data#998zhemao-openai wants to merge 2 commits intospr/main/91823ccdfrom
Conversation
zhemao-openai
force-pushed
the
spr/main/90324e28
branch
from
bf88571 to
56500e8
Compare
zhemao-openai
force-pushed
the
spr/main/e69dfb01
branch
from
7486417 to
04b9c46
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56500e8c83
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| module br_cdc_stable_data_fpv_monitor #( | ||
| parameter int Width = 1, | ||
| parameter logic [Width-1:0] InitValue = '0, | ||
| parameter bit EnableRegisterResetActive = 1, |
There was a problem hiding this comment.
br_cdc_stable_data_test_suite sweeps "RegisterResetActive" in cdc/fpv/BUILD.bazel (lines 681-684), but the new monitor exposes that control as EnableRegisterResetActive, so the suite’s override does not target any top-level parameter. In the FPV runs for this monitor, that either triggers an unknown-parameter error on strict elaborators or silently leaves the monitor at its default reset behavior, meaning the RegisterResetActive=0 scenario is never actually verified.
Useful? React with 👍 / 👎.
**Stack**: - #998 - #997 - #995 - #996 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
commit-id:e69dfb01
commit-id:90324e28
zhemao-openai
force-pushed
the
spr/main/90324e28
branch
from
56500e8 to
f38ee72
Compare
commit-id:9c23baf9 --- **Stack**: - #998 - #997 - #995 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
1 participant
Stack: