Add br_cdc_stable_data_autoupdate module#999
Conversation
commit-id:9c23baf9
commit-id:91823ccd
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93914fc62a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| `BR_REGLIX(src_data_reg, src_data, src_valid, InitValue, src_clk, src_rst) | ||
|
|
||
| assign src_valid = src_data != src_data_reg; |
There was a problem hiding this comment.
This logic can drop updates whenever src_data changes while br_cdc_stable_data is backpressured: src_data_reg is updated on any src_valid, but src_valid itself is just src_data != src_data_reg, so a change that occurs when src_ready is low is consumed into the shadow register and then deasserted before a transfer happens. In that case the destination never receives the new value (and with assertions enabled, no_reg_overflow_A can also fire), so two source updates within one CDC transfer interval can leave dst_data permanently stale.
Useful? React with 👍 / 👎.
1 participant
Stack: