Open
Conversation
These flags are passed directly to the driver.
There was a problem hiding this comment.
Pull Request Overview
This PR adds an xlsynth_flags attribute to multiple xlsynth build rules, enabling users to pass custom flags directly to the xlsynth driver. This pattern is consistent with other language rules (e.g., rustc_flags, copts) and provides flexibility for debugging and handling edge cases.
Key Changes:
- Added
xlsynth_flagsstring_list attribute to all xlsynth-related build rules - Updated command construction to append extra flags when provided
- Standardized load statement ordering across files
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ir_to_gates.bzl | Added xlsynth_flags attribute and flag handling to ir_to_gates rule |
| ir_to_delay_info.bzl | Added xlsynth_flags attribute and flag handling to ir_to_delay_info rule |
| ir_prove_equiv_test.bzl | Added xlsynth_flags attribute and flag handling to ir_prove_equiv_test rule |
| dslx_to_sv_types.bzl | Added xlsynth_flags attribute and flag handling to dslx_to_sv_types rule |
| dslx_to_pipeline_eco.bzl | Added xlsynth_flags attribute and flag handling to dslx_to_pipeline_eco rule |
| dslx_to_pipeline.bzl | Added xlsynth_flags attribute and flag handling to dslx_to_pipeline rule |
| dslx_to_ir.bzl | Added xlsynth_flags attribute and flag handling to dslx_to_ir rule (both dslx2ir and ir2opt stages) |
| dslx_stitch_pipeline.bzl | Added xlsynth_flags attribute and flag handling to dslx_stitch_pipeline rule |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cdleary
approved these changes
Oct 22, 2025
Contributor
cdleary
left a comment
cdleary
left a comment
There was a problem hiding this comment.
Worth a presubmit test to make sure we don't regress it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These flags are passed directly to the driver. This is similar to other rules for other languages (eg: rustc_flags, copts, etc.) and is useful for debugging or handling weird corner cases.