Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duckdb: enhance precompiled package handling #6642

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

ArthurVasseur
Copy link
Contributor

No description provided.

@ArthurVasseur
Copy link
Contributor Author

Don't know why the ci is failing @waruqi
error: @programdir/core/package/package.lua:2498: bad argument #1 to 'for iterator' (table expected, got nil)

@ArthurVasseur ArthurVasseur marked this pull request as ready for review March 20, 2025 19:52
package:add("versions", "v1.2.1", "de02a9e3e64b41ea7844aa04ad7e72519ca131327e739cd344a6ba476fb31c0f")
end
elseif package:is_plat("linux") then
if package:config("shared") then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cannot use package:config in on_source. all configs are not inited here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So how can I differentiate between precompiled packages in static/shared, in the on_source?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no way now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants