Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duckdb: enhance precompiled package handling #6642

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

duckdb: enhance precompiled package handling #6642

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5d5f1e6
duckdb: enhance platform-specific precompiled package handling
ArthurVasseur Mar 19, 2025
49e9414
duckdb: update platform identifier from macos to macosx
ArthurVasseur Mar 19, 2025
398684d
duckdb: add CMake dependency for non precompiled packages
ArthurVasseur Mar 19, 2025
381baf5
duckdb: update download URL for source packages
ArthurVasseur Mar 19, 2025
4b53f66
duckdb: fix typo
ArthurVasseur Mar 19, 2025
dbe44c8
duckdb: update version hashes
ArthurVasseur Mar 19, 2025
cc79053
duckdb: fix dependency condition for CMake
ArthurVasseur Mar 19, 2025
8c61807
duckdb: enhance CMake installation with configurable build options
ArthurVasseur Mar 19, 2025
46da45e
duckdb: update on_test function
ArthurVasseur Mar 19, 2025
49606a6
refactor xmake.lua to simplify platform-specific hooks and correct C+…
ArthurVasseur Mar 19, 2025
e438e36
duckdb: add configuration options for static build and disable unit t…
ArthurVasseur Mar 19, 2025
cce20b5
duckdb: using "windows", "macosx", "linux" others platforms are exper…
ArthurVasseur Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 97 additions & 25 deletions packages/d/duckdb/xmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,38 +3,110 @@ package("duckdb")
set_description("DuckDB is an in-process SQL OLAP Database Management System")
set_license("MIT")

add_urls("https://github.com/duckdb/duckdb/releases/download/$(version)/libduckdb-src.zip",
"https://github.com/duckdb/duckdb.git")
add_versions("v1.2.1", "c7f21c12039e951dbb74e064ba218a4ca8b4b0a612d40c62d95a858ecaf2fb53")
add_versions("v1.1.3", "66beec9f299c56f508fec3d647faa86a596d39b2d4e26bd6991b29d07b818f83")
add_versions("v1.1.2", "8b30ec65addfe423fc18f8403bd958953d01a3193ec8b3bc2e43073433d94e47")
add_versions("v1.1.1", "48f1ca566ae0f73fb536aec22d599917f47c26ea7ae300380e7ae3f39e29af4d")
add_versions("v1.0.0", "482c7f090cac4408eed5b02708b6a54168c1875c2c6d8042d8344edee3f70eb7")
add_versions("v0.10.3", "f22ed5058188c81886dfdda80c6c46b7df2ed0a623a348c78ac8372451c84497")
add_versions("v0.10.2", "6bab203dc2e10432edbefda7be7043f73f17c8898ba81ce3aa2319e7e2d5af10")
add_versions("v0.10.1", "70ec6ffefd9a04bf9fcdc1a4949611f9633f10f0e3b9cead1425b926a54d0f89")
add_versions("v0.10.0", "385e27aa67712813e4a07389465c4c5c45c431d97cddd35713b8a306d2a86f2d")

on_install("macosx", "linux", function (package)
io.writefile("xmake.lua", [[
add_rules("mode.debug", "mode.release")
set_languages("c++17")
target("duckdb")
set_kind("$(kind)")
add_files("duckdb.cpp")
add_headerfiles("duckdb.hpp", "duckdb.h")
]])
import("package.tools.xmake").install(package)
on_source("windows", "macosx", "linux", function(package)
local precompiled = false
if package:is_plat("windows") then
if package:is_arch("x64", "x86_64") then
precompiled = true
package:add("urls", "https://github.com/duckdb/duckdb/releases/download/$(version)/libduckdb-windows-amd64.zip")
package:add("versions", "v1.2.1", "c977230a701d6b274fe63166868c8e2bc4ec23cf42c44f08f22bdcd8ed4a8e31")
elseif package:is_arch("arm64") then
precompiled = true
package:add("urls", "https://github.com/duckdb/duckdb/releases/download/$(version)/libduckdb-windows-arm64.zip")
package:add("versions", "v1.2.1", "de02a9e3e64b41ea7844aa04ad7e72519ca131327e739cd344a6ba476fb31c0f")
end
elseif package:is_plat("linux") then
if package:config("shared") then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cannot use package:config in on_source. all configs are not inited here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So how can I differentiate between precompiled packages in static/shared, in the on_source?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no way now.

if package:is_arch("x64", "x86_64") then
precompiled = true
package:add("urls", "https://github.com/duckdb/duckdb/releases/download/$(version)/libduckdb-linux-amd64.zip")
package:add("versions", "v1.2.1", "8dda081c84ef1da07f19f953ca95e1c6db9b6851e357444a751ad45be8a14d36")
elseif package:is_arch("arm64") then
precompiled = true
package:add("urls", "https://github.com/duckdb/duckdb/releases/download/$(version)/libduckdb-linux-arm64.zip")
package:add("versions", "v1.2.1", "b1fc7c892414fdc286a7d99cd374634deb586e0fcccc87cb84a2b52272f93bfd")
end
elseif package:config("static") then
if package:is_arch("x64", "x86_64") then
precompiled = true
package:add("urls", "https://github.com/duckdb/duckdb/releases/download/$(version)/static-lib-linux-amd64.zip")
package:add("versions", "v1.2.1", "be614d4b36621bce1da8ad545fd0fc46c6094232ce5fe8a135bf69455110bfa1")
elseif package:is_arch("arm64") then
precompiled = true
package:add("urls", "https://github.com/duckdb/duckdb/releases/download/$(version)/static-lib-linux-arm64.zip")
package:add("versions", "v1.2.1", "ab5d43238972cfb7ae1852f8890103a056d09ff5ce60623a8515729c49e1d6c0")
end
end
elseif package:is_plat("macosx") then
if package:config("shared") then
precompiled = true
package:add("urls", "https://github.com/duckdb/duckdb/releases/download/$(version)/libduckdb-osx-universal.zip")
package:add("versions", "v1.2.1", "5045ad331e6e738ba4d2299e8726f200be82f6da961f208973f48df7a4532ce1")
elseif package:config("static") then
if package:is_arch("x64", "x86_64") then
precompiled = true
package:add("urls", "https://github.com/duckdb/duckdb/releases/download/$(version)/static-lib-osx-amd64.zip")
package:add("versions", "v1.2.1", "be614d4b36621bce1da8ad545fd0fc46c6094232ce5fe8a135bf69455110bfa1")
elseif package:is_arch("arm64") then
precompiled = true
package:add("urls", "https://github.com/duckdb/duckdb/releases/download/$(version)/static-lib-osx-arm64.zip")
package:add("versions", "v1.2.1", "ab5d43238972cfb7ae1852f8890103a056d09ff5ce60623a8515729c49e1d6c0")
end
end
end

if not precompiled then
package:add("urls", "https://github.com/duckdb/duckdb/archive/refs/tags/$(version).zip",
"https://github.com/duckdb/duckdb.git")
package:add("versions", "v1.2.1", "8d17ce47dc16c8e3dde41a09916eb63034cb19dd2c6bd71b90372261a43b8b71")
package:add("versions", "v1.1.3", "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855")
package:add("versions", "v1.1.2", "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855")
package:add("versions", "v1.1.1", "cedf308dca577d2c5e44b34948529cb0ce932da27cd54ed611c926d49473c732")
package:add("versions", "v1.0.0", "6b8b410745dd763058af727ae45a37b34c22418c866dd3df94cbb3a0bc622992")
package:add("versions", "v0.10.3", "9e7372f2b23cada55200e07da407f2c3c261f9aaeb364b8e0908f0682bf3a895")
package:add("versions", "v0.10.2", "309af78e1ad8326841454bcd7203bb04ee8ca8279de3f6357a8a3e4c94842989")
package:add("versions", "v0.10.1", "1da8dbe3c984f82ff35cb40982e9605fd4670681e6f9ee44931facc41c782c58")
package:add("versions", "v0.10.0", "9162e6ef0fc53cdfe4b9ded5c4c3260a4cd8e2d812a953d2d8bd0b9afdb5e09c")
end
package:data_set("precompiled", precompiled)
end)

on_load("windows", "macosx", "linux", function (package)
if not package:data("precompiled") then
package:add("deps", "cmake")
end
end)

on_install("windows", "macosx", "linux", function (package)
if package:data("precompiled") then
os.trycp("*.dll", package:installdir("lib"))
os.trycp("*.lib", package:installdir("lib"))
os.trycp("*.a", package:installdir("lib"))
os.trycp("*.dylib", package:installdir("lib"))
os.trycp("*.so", package:installdir("lib"))
os.trycp("*.h", package:installdir("include"))
os.trycp("*.hpp", package:installdir("include"))
return
end

local configs = {}
table.insert(configs, "-DCMAKE_BUILD_TYPE=" .. (package:debug() and "Debug" or "Release"))
table.insert(configs, "-DBUILD_SHARED_LIBS=" .. (package:config("shared") and "ON" or "OFF"))
table.insert(configs, "-DEXTENSION_STATIC_BUILD=" .. (package:config("shared") and "ON" or "OFF"))
table.insert(configs, "-DBUILD_UNITTESTS=0")
table.insert(configs, "-DBUILD_SHELL=0")

import("package.tools.cmake").install(package, configs)
end)

on_test(function (package)
on_test("windows", "macosx", "linux", function (package)
assert(package:check_cxxsnippets({test = [[
#include "duckdb.hpp"
using namespace duckdb;

void test() {
DuckDB db(nullptr);
Connection con(db);
}
]]}, {configs = {languages = "cxx17"}}))
]]}, {configs = {languages = "c++17"}}))
end)
Loading