Stop writing to column tables if quota is exceeded #11580
Conversation
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
aavdonkin
force-pushed
the
columnshard_quota
branch
from
dda12f2 to
77e9d8b
Compare
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -318,7 +318,8 @@ class TConfigureParts: public TSubOperationState { | |||
| ui64(OperationId.GetTxId()), | |||
| columnShardTxBody, seqNo, | |||
| context.SS->SelectProcessingParams(txState->TargetPathId)); | |||
|
|
|||
| const ui64 subDomainPathId = context.SS->ResolvePathIdForDomain(txState->TargetPathId).LocalPathId; | |||
There was a problem hiding this comment.
Передавать явно.
В устоявшемся режиме работы пара [schemeshard-tablet-id,schemeshard-local-path-id] неизменна, известна изначально, и вообще-то должна быть неделима -- это полный path-id базы.
Поиск schemeshard-local-path-id на стороне columnshard'а будет нужен только в переходной фазе, когда кластер будет переходить с текущей версии на эту новую, и версии взаимодействующих columnshard'ов и schemeshard'а на какое-то время будут отличаться.
| @@ -318,7 +318,8 @@ class TConfigureParts: public TSubOperationState { | |||
| ui64(OperationId.GetTxId()), | |||
| columnShardTxBody, seqNo, | |||
| context.SS->SelectProcessingParams(txState->TargetPathId)); | |||
|
|
|||
| const ui64 subDomainPathId = context.SS->ResolvePathIdForDomain(txState->TargetPathId).LocalPathId; | |||
There was a problem hiding this comment.
И я бы добавил параметр в конструктор TEvColumnShard::TEvProposeTransaction, а не добавлял schemeshard-local-path-id отдельно -- ровно потому, что это пара к schemeshard-tablet-id.
| @@ -173,6 +173,16 @@ bool TSpecialValuesInitializer::DoExecute(NTabletFlatExecutor::TTransactionConte | |||
| return false; | |||
| } | |||
|
|
|||
| if (!Schema::GetSpecialValueOpt(db, Schema::EValueIds::SubDomainLocalPathId, Self->SpaceWatcher->SubDomainPathId)) { | |||
There was a problem hiding this comment.
Хорошо видна неразбериха с именами. Это просто комментарий. Знаю, что сделано по образу и подобию datashard'а.
CurrentSchemeShardId и SubDomainLocalPathId составляют тесную пару -- полный path-id базы, а в именах не имеют ничего похожего.
SubDomainLocalPathId и SubDomainPathId есть одно и то же, а называются по-разному. Формально правильно -- SubDomainLocalPathId. SubDomainPathId -- сокращение и рудимент времён, когда schemeshard в кластере мог быть только один.
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ |
|
⚪ |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
…saction in which it is not required
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Additional information
...