Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for storage exhaustion when deleting rows #13760

Merged
merged 4 commits into from
Feb 24, 2025
Merged

Add test for storage exhaustion when deleting rows #13760

merged 4 commits into from
Feb 24, 2025

Conversation

avevad
Copy link
Contributor

@avevad avevad commented Jan 23, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

This resolves #13653

@avevad avevad self-assigned this Jan 23, 2025
@avevad avevad force-pushed the test-storage-exhaustion-delete branch from 851ce92 to 1977ab5 Compare January 23, 2025 13:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

⚪ 2025-01-23 13:23:47 UTC Pre-commit check linux-x86_64-release-asan for 458cd59 has started.
⚪ 2025-01-23 13:24:23 UTC Artifacts will be uploaded here
⚪ 2025-01-23 13:27:13 UTC ya make is running...
🟡 2025-01-23 13:46:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40 33 0 2 3 2

⚪ 2025-01-23 13:47:05 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-23 13:58:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
7 (only retried tests) 1 0 2 1 3

⚪ 2025-01-23 13:58:38 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-23 14:09:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6 (only retried tests) 1 0 3 0 2

🟢 2025-01-23 14:09:30 UTC Build successful.
🟢 2025-01-23 14:09:44 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: bd79c91 merge: 458cd59 diff diff %
ydbd size 3 858 261 672 Bytes 3 858 261 576 Bytes -96 Bytes -0.000%
ydbd stripped size 1 349 573 328 Bytes 1 349 573 264 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

⚪ 2025-01-23 13:25:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 458cd59 has started.
⚪ 2025-01-23 13:25:18 UTC Artifacts will be uploaded here
⚪ 2025-01-23 13:27:46 UTC ya make is running...
🟡 2025-01-23 13:46:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
53 49 0 3 0 1

⚪ 2025-01-23 13:47:06 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-23 13:55:53 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6 (only retried tests) 5 0 0 0 1

🟢 2025-01-23 13:55:59 UTC Build successful.
🟢 2025-01-23 13:56:08 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: bd79c91 merge: 458cd59 diff diff %
ydbd size 2 220 428 304 Bytes 2 220 428 304 Bytes 0 Bytes 0.000%
ydbd stripped size 469 670 576 Bytes 469 670 576 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2025 •
edited
Loading

⚪ 2025-01-24 12:26:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8aadf4f has started.
⚪ 2025-01-24 12:27:05 UTC Artifacts will be uploaded here
⚪ 2025-01-24 12:29:29 UTC ya make is running...
🟡 2025-01-24 12:49:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
53 49 0 3 0 1

⚪ 2025-01-24 12:49:09 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-24 12:57:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6 (only retried tests) 4 0 1 0 1

⚪ 2025-01-24 12:57:39 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-24 12:58:42 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4 (only retried tests) 2 0 1 0 1

🟢 2025-01-24 12:58:53 UTC Build successful.
🟢 2025-01-24 12:59:02 UTC ydbd size 2.1 GiB changed* by +15.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 062fa7b merge: 8aadf4f diff diff %
ydbd size 2 220 978 568 Bytes 2 220 994 656 Bytes +15.7 KiB +0.001%
ydbd stripped size 469 726 352 Bytes 469 728 016 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2025 •
edited
Loading

⚪ 2025-01-24 12:27:33 UTC Pre-commit check linux-x86_64-release-asan for 8aadf4f has started.
⚪ 2025-01-24 12:27:49 UTC Artifacts will be uploaded here
⚪ 2025-01-24 12:30:16 UTC ya make is running...
🟡 2025-01-24 12:55:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40 27 0 1 9 3

⚪ 2025-01-24 12:55:17 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-24 13:06:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14 (only retried tests) 8 0 2 1 3

⚪ 2025-01-24 13:06:13 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-24 13:16:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8 (only retried tests) 2 0 1 2 3

🟢 2025-01-24 13:17:06 UTC Build successful.
🟢 2025-01-24 13:17:20 UTC ydbd size 3.6 GiB changed* by +30.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 062fa7b merge: 8aadf4f diff diff %
ydbd size 3 859 256 568 Bytes 3 859 287 688 Bytes +30.4 KiB +0.001%
ydbd stripped size 1 349 750 768 Bytes 1 349 756 080 Bytes +5.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk
Copy link
Collaborator

Предлагаю @zverevgeny посмотреть

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 15:45:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 843a9bc has started.
⚪ 2025-02-13 15:45:27 UTC Artifacts will be uploaded here
⚪ 2025-02-13 15:47:44 UTC ya make is running...
🟡 2025-02-13 16:12:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58 50 0 1 4 3

⚪ 2025-02-13 16:12:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-13 16:36:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8 (only retried tests) 3 0 2 0 3

⚪ 2025-02-13 16:36:34 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-13 16:59:11 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5 (only retried tests) 2 0 1 0 2

🟢 2025-02-13 16:59:19 UTC Build successful.
🟡 2025-02-13 16:59:29 UTC ydbd size 2.1 GiB changed* by +205.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 54f9570 merge: 843a9bc diff diff %
ydbd size 2 230 621 472 Bytes 2 230 832 344 Bytes +205.9 KiB +0.009%
ydbd stripped size 473 503 224 Bytes 473 549 048 Bytes +44.8 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 15:46:22 UTC Pre-commit check linux-x86_64-release-asan for 843a9bc has started.
⚪ 2025-02-13 15:46:28 UTC Artifacts will be uploaded here
⚪ 2025-02-13 15:48:44 UTC ya make is running...
🟡 2025-02-13 16:13:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
45 38 0 1 2 4

⚪ 2025-02-13 16:13:38 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-13 16:30:40 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
7 (only retried tests) 2 0 0 2 3

🟢 2025-02-13 16:30:50 UTC Build successful.
🟡 2025-02-13 16:31:05 UTC ydbd size 3.6 GiB changed* by +461.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 54f9570 merge: 843a9bc diff diff %
ydbd size 3 879 350 288 Bytes 3 879 823 024 Bytes +461.7 KiB +0.012%
ydbd stripped size 1 358 503 552 Bytes 1 358 720 480 Bytes +211.8 KiB +0.016%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

zverevgeny
zverevgeny previously approved these changes Feb 13, 2025
View reviewed changes
@avevad avevad enabled auto-merge (squash) February 13, 2025 16:23
@avevad avevad added the rebase-and-check Rebase PR with the current base branch and check label Feb 14, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Feb 14, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

⚪ 2025-02-14 17:13:11 UTC Pre-commit check linux-x86_64-release-asan for 7921d0f has started.
⚪ 2025-02-14 17:15:17 UTC Artifacts will be uploaded here
⚪ 2025-02-14 17:17:39 UTC ya make is running...
🟢 2025-02-14 17:30:08 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
45 35 0 0 6 4

🟢 2025-02-14 17:30:22 UTC Build successful.
🟢 2025-02-14 17:30:34 UTC ydbd size 3.6 GiB changed* by +112 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: a76b6a1 merge: 7921d0f diff diff %
ydbd size 3 885 196 352 Bytes 3 885 196 464 Bytes +112 Bytes +0.000%
ydbd stripped size 1 360 360 112 Bytes 1 360 360 048 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

⚪ 2025-02-14 17:16:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7921d0f has started.
⚪ 2025-02-14 17:23:35 UTC Artifacts will be uploaded here
⚪ 2025-02-14 17:25:51 UTC ya make is running...
🟡 2025-02-14 17:52:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58 51 0 1 1 5

⚪ 2025-02-14 17:52:59 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-14 18:08:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6 (only retried tests) 0 0 1 1 4

⚪ 2025-02-14 18:08:10 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-14 18:23:10 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6 (only retried tests) 1 0 1 0 4

🟢 2025-02-14 18:23:19 UTC Build successful.
🟢 2025-02-14 18:23:29 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: c15923e merge: 7921d0f diff diff %
ydbd size 2 234 037 192 Bytes 2 234 037 192 Bytes 0 Bytes 0.000%
ydbd stripped size 474 107 800 Bytes 474 107 800 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 24, 2025 •
edited
Loading

⚪ 2025-02-24 10:13:42 UTC Pre-commit check linux-x86_64-release-asan for 4a448e5 has started.
⚪ 2025-02-24 10:13:53 UTC Artifacts will be uploaded here
⚪ 2025-02-24 10:16:17 UTC ya make is running...
🟢 2025-02-24 10:34:29 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
45 34 0 0 7 4

🟢 2025-02-24 10:34:36 UTC Build successful.
🟢 2025-02-24 10:34:48 UTC ydbd size 3.6 GiB changed* by +4.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1baf0a4 merge: 4a448e5 diff diff %
ydbd size 3 899 474 264 Bytes 3 899 478 328 Bytes +4.0 KiB +0.000%
ydbd stripped size 1 365 154 768 Bytes 1 365 155 344 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 24, 2025 •
edited
Loading

⚪ 2025-02-24 10:14:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4a448e5 has started.
⚪ 2025-02-24 10:15:10 UTC Artifacts will be uploaded here
⚪ 2025-02-24 10:17:31 UTC ya make is running...
🟡 2025-02-24 10:39:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58 44 0 2 6 6

⚪ 2025-02-24 10:39:58 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-24 10:50:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14 (only retried tests) 8 0 1 2 3

⚪ 2025-02-24 10:51:07 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-24 11:07:50 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5 (only retried tests) 3 0 0 0 2

🟢 2025-02-24 11:07:56 UTC Build successful.
🟢 2025-02-24 11:08:08 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 7954aba merge: 4a448e5 diff diff %
ydbd size 2 242 825 656 Bytes 2 242 825 656 Bytes 0 Bytes 0.000%
ydbd stripped size 474 855 096 Bytes 474 855 096 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@avevad avevad requested a review from zverevgeny February 24, 2025 11:37
@avevad avevad merged commit cb5d0e3 into ydb-platform:main Feb 24, 2025
12 checks passed
@serbel324 serbel324 mentioned this pull request Feb 25, 2025
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 25, 2025
Merged
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
Add test for storage exhaustion when deleting rows (ydb-platform#13760)
3da8d40
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
This was referenced Mar 10, 2025
Merged
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@blinkov
Add test for storage exhaustion when deleting rows (#13760)
dc365ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zverevgeny zverevgeny zverevgeny approved these changes

@maximyurchuk maximyurchuk Awaiting requested review from maximyurchuk

Assignees

@avevad avevad

Labels
area/cs/write not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data deletion doesn't lead to disk exhaustion
3 participants
@avevad @maximyurchuk @zverevgeny