Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YDB CLI: make commiting disabled by default in topic read #15880

Conversation

a-serebryanskiy
Copy link
Collaborator

@a-serebryanskiy a-serebryanskiy commented Mar 18, 2025

Changelog entry

From now on reading topic without a consumer will not try to commit.

Changelog category

  • Not for changelog

Description for reviewers

...

@a-serebryanskiy a-serebryanskiy requested a review from a team as a code owner March 18, 2025 11:45
Copy link

github-actions bot commented Mar 18, 2025

🟢 2025-03-19 07:15:10 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 18, 2025

2025-03-18 11:47:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 271424c has started.
2025-03-18 11:48:01 UTC Artifacts will be uploaded here
2025-03-18 11:50:50 UTC ya make is running...
🟡 2025-03-18 12:04:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1076 1064 0 1 7 4

2025-03-18 12:04:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-18 12:15:51 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11 (only retried tests) 3 0 0 3 5

🟢 2025-03-18 12:15:57 UTC Build successful.
🟢 2025-03-18 12:16:08 UTC ydbd size 2.1 GiB changed* by +304 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 31b3314 merge: 271424c diff diff %
ydbd size 2 299 410 176 Bytes 2 299 410 480 Bytes +304 Bytes +0.000%
ydbd stripped size 481 262 848 Bytes 481 262 976 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 18, 2025

2025-03-18 11:48:07 UTC Pre-commit check linux-x86_64-release-asan for 271424c has started.
2025-03-18 11:48:22 UTC Artifacts will be uploaded here
2025-03-18 11:50:38 UTC ya make is running...
🟢 2025-03-18 12:12:13 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
647 627 0 0 12 8

🟢 2025-03-18 12:12:24 UTC Build successful.
🟢 2025-03-18 12:12:38 UTC ydbd size 3.8 GiB changed* by -6.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: b44f116 merge: 271424c diff diff %
ydbd size 4 048 583 160 Bytes 4 048 576 312 Bytes -6.7 KiB -0.000%
ydbd stripped size 1 400 534 248 Bytes 1 400 533 160 Bytes -1.1 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@a-serebryanskiy a-serebryanskiy merged commit c1779ca into ydb-platform:main Mar 19, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants