Skip to content

YDB CLI: make commiting disabled by default in topic read #15880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

YDB CLI: make commiting disabled by default in topic read #15880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ydb/public/lib/ydb_cli/commands/ydb_service_topic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,7 +792,7 @@ namespace NYdb::NConsoleClient {
.StoreResult(&IdleTimeout_);
config.Opts->AddLongOption("commit", "Commit messages after successful read")
.Optional()
.DefaultValue(true)
.DefaultValue(false)
.StoreResult(&Commit_);
config.Opts->AddLongOption("limit", "Limit on message count to read, 0 - unlimited. "
"If avobe 0, processing stops when either topic is empty, or the specified limit reached. "
Expand All @@ -808,7 +808,7 @@ namespace NYdb::NConsoleClient {
.RequiredArgument("TIMESTAMP")
.Optional()
.Handler1T<TString>(TimestampOptionHandler(&Timestamp_));
config.Opts->AddLongOption("partition-ids", "Comma separated list of partition ids to read from. If not specified, messages are read from all partitions.")
config.Opts->AddLongOption("partition-ids", "Comma separated list of partition ids to read from. If not specified, messages are read from all partitions. E.g. \"--partition-ids 0,1,10\"")
.Optional()
.SplitHandler(&PartitionIds_, ',');

Expand Down
Loading