Skip to content

Conversation

@d4wae89d498
Copy link
Contributor

Corrected the URL for 'wasm-pack' and updated the file listing after the build.

@cla-bot
Copy link

cla-bot bot commented Dec 5, 2025

Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @d4wae89d498 on file. In order for us to review and merge your code, please sign:

  • For individual contribution: our CLA
  • for Bounty submission, if you are an individual: our T&C
  • for Bounty submission, if you are a company: our T&C
    to get yourself added.

If you already signed one of this document, just wait to be added to the bot config.

@aquint-zama
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Dec 5, 2025
@cla-bot
Copy link

cla-bot bot commented Dec 5, 2025

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the links to the new official wasm-pack location !

@IceTDrinker
Copy link
Member

@d4wae89d498 your commit message does not conform to our standard, please change it to:

chore: Fix wasm-pack URL and update build output listing

@d4wae89d498 d4wae89d498 changed the title Fix wasm-pack URL and update build output listing chore: Fix wasm-pack URL and update build output listing Dec 8, 2025
@d4wae89d498 d4wae89d498 changed the title chore: Fix wasm-pack URL and update build output listing docs: Fix wasm-pack URL and update build output listing Dec 8, 2025
@d4wae89d498
Copy link
Contributor Author

Done

@IceTDrinker
Copy link
Member

@d4wae89d498 thanks, it seems we have a small issue at the moment on one of our CI tool, I'll let you know if you need to rebase once we have a fix

@d4wae89d498
Copy link
Contributor Author

I just made the 'fix' keyword lowercase. I'll wait for your updates.

@IceTDrinker
Copy link
Member

@d4wae89d498 we should have a fix for the issue in CI, can you try rebasing on our latest main please ?

@IceTDrinker
Copy link
Member

@d4wae89d498 did you see my previous message ? :)

@d4wae89d498
Copy link
Contributor Author

d4wae89d498 commented Dec 10, 2025

@IceTDrinker Yes sorry I was busy yesterday. I will do it tonight :)

@IceTDrinker
Copy link
Member

no worries @d4wae89d498 :) just be careful I see a potential conflict on one of the files, hopefully the conflict is very small

@d4wae89d498
Copy link
Contributor Author

d4wae89d498 commented Dec 10, 2025

@IceTDrinker I guess I just rebased successfully, as promised. I took care of the small conflict, thank you for the heads-up.

@IceTDrinker
Copy link
Member

thanks @d4wae89d498 just relaunched the CI

@IceTDrinker
Copy link
Member

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@d4wae89d498
Copy link
Contributor Author

@IceTDrinker I will do it tonight. Sorry for the mistake. Have a good day 🙂

@IceTDrinker
Copy link
Member

no worries

Corrected the URL for 'wasm-pack' and updated the file listing after the build.
@d4wae89d498
Copy link
Contributor Author

d4wae89d498 commented Dec 15, 2025

@IceTDrinker Hello, I just signed the commit.

@IceTDrinker
Copy link
Member

hello @d4wae89d498 thanks, I will take a look :)

@IceTDrinker
Copy link
Member

seems like, we have another CI issue... we will manage this on our end

@IceTDrinker
Copy link
Member

@d4wae89d498 given we may not be able to fix this right away, would you be ok if I open the PR myself by crediting you with co-authored-by https://docs.github.com/articles/creating-a-commit-with-multiple-authors ?

@d4wae89d498
Copy link
Contributor Author

@IceTDrinker hello yes no problem! I wish you a good day

@IceTDrinker
Copy link
Member

superseded by #3166

thanks again, and sorry about the CI issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants