-
Notifications
You must be signed in to change notification settings - Fork 315
docs: Fix wasm-pack URL and update build output listing #3087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @d4wae89d498 on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
IceTDrinker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the links to the new official wasm-pack location !
|
@d4wae89d498 your commit message does not conform to our standard, please change it to:
|
|
Done |
|
@d4wae89d498 thanks, it seems we have a small issue at the moment on one of our CI tool, I'll let you know if you need to rebase once we have a fix |
|
I just made the 'fix' keyword lowercase. I'll wait for your updates. |
|
@d4wae89d498 we should have a fix for the issue in CI, can you try rebasing on our latest main please ? |
|
@d4wae89d498 did you see my previous message ? :) |
|
@IceTDrinker Yes sorry I was busy yesterday. I will do it tonight :) |
|
no worries @d4wae89d498 :) just be careful I see a potential conflict on one of the files, hopefully the conflict is very small |
|
@IceTDrinker I guess I just rebased successfully, as promised. I took care of the small conflict, thank you for the heads-up. |
|
thanks @d4wae89d498 just relaunched the CI |
|
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
|
@IceTDrinker I will do it tonight. Sorry for the mistake. Have a good day 🙂 |
|
no worries |
Corrected the URL for 'wasm-pack' and updated the file listing after the build.
|
@IceTDrinker Hello, I just signed the commit. |
|
hello @d4wae89d498 thanks, I will take a look :) |
|
seems like, we have another CI issue... we will manage this on our end |
|
@d4wae89d498 given we may not be able to fix this right away, would you be ok if I open the PR myself by crediting you with co-authored-by https://docs.github.com/articles/creating-a-commit-with-multiple-authors ? |
|
@IceTDrinker hello yes no problem! I wish you a good day |
|
superseded by #3166 thanks again, and sorry about the CI issues |
Corrected the URL for 'wasm-pack' and updated the file listing after the build.