feat: make init job ttlSecondsAfterFinished configurable and default 1h #389
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
LGTM, what do you think @monotek? |
monotek
requested changes
Feb 2, 2026
| initJob: | ||
| randomName: true | ||
| # specify how long after finish pods are deleted | ||
| ttlSecondsAfterFinished: 3600 |
Member
There was a problem hiding this comment.
please keep the current valu as default here.
Suggested change
| ttlSecondsAfterFinished: 3600 | |
| ttlSecondsAfterFinished: 300 |
Collaborator
There was a problem hiding this comment.
@monotek why? I believe the change was done on purpose to make the default more user friendly. And it should not hurt?
Member
There was a problem hiding this comment.
If we change a default value it changes for all users updating the chart unexpectingly.
If we change a default we should raise the major version of the chart an add the change to the upgrading section of the readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
ttlSecondsAfterFinishedttlSecondsAfterFinishedto 1h as 5m seams not really like a production useful valueWhich issue this PR fixes
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[ ] Upgrading instructions are documented in the zammad/README.md(not required)